From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard.weinberger@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] all arches, signal: Move restart_block to struct task_struct
Date: Wed, 29 Oct 2014 19:12:57 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1410291908290.5308@nanos> (raw)
In-Reply-To: <43c88012a4959cd427ab634906e697fbc524e847.1414604015.git.luto@amacapital.net>
On Wed, 29 Oct 2014, Andy Lutomirski wrote:
> If an attacker can cause a controlled kernel stack overflow,
> overwriting the restart block is a very juicy exploit target.
> Moving the restart block to struct task_struct prevents this
> exploit.
>
> Note that there are other fields in thread_info that are also easy
> targets, at least on some architectures.
>
> It's also a decent simplification, since the restart code is more or
> less identical on all architectures.
I think that's the most important change. Moving common stuff into
common code. The side effect of slightly reducing the attack surface
is nice, but as Al pointed out not really the big win here.
Thanks,
tglx
next prev parent reply other threads:[~2014-10-29 18:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 17:36 [PATCH v2] all arches, signal: Move restart_block to struct task_struct Andy Lutomirski
2014-10-29 18:12 ` Thomas Gleixner [this message]
2014-10-29 18:12 ` Thomas Gleixner
2014-11-10 22:03 ` Andy Lutomirski
2014-11-11 2:13 ` David Miller
2014-11-11 2:13 ` David Miller
2014-11-11 10:52 ` Richard Weinberger
2014-12-01 14:55 ` Andy Lutomirski
2014-12-01 14:55 ` Andy Lutomirski
2014-12-03 23:37 ` Andrew Morton
2014-12-03 23:37 ` Andrew Morton
2014-12-03 23:38 ` Andy Lutomirski
2014-12-03 23:53 ` Andrew Morton
2014-12-04 0:01 ` Andy Lutomirski
2014-12-04 0:01 ` Andy Lutomirski
2014-12-05 11:13 ` Chuck Ebbert
2014-12-08 22:51 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1410291908290.5308@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox