From: Thomas Gleixner <tglx@linutronix.de>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] fixmap: change temp variable name
Date: Mon, 12 Oct 2015 11:05:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1510121104180.6097@nanos> (raw)
In-Reply-To: <1444637308-23390-1-git-send-email-yalin.wang2010@gmail.com>
On Mon, 12 Oct 2015, yalin wang wrote:
> Change temp variable name addr to ____addr,
> so that not conflict with the caller's variable name,
> it will build error if call like this:
> __set_fixmap_offset(idx, addr, flags)
Can't we just use inlines to avoid this kind of crap?
Thanks,
tglx
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> include/asm-generic/fixmap.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h
> index 1cbb833..91ecaed 100644
> --- a/include/asm-generic/fixmap.h
> +++ b/include/asm-generic/fixmap.h
> @@ -72,10 +72,10 @@ static inline unsigned long virt_to_fix(const unsigned long vaddr)
> /* Return a pointer with offset calculated */
> #define __set_fixmap_offset(idx, phys, flags) \
> ({ \
> - unsigned long addr; \
> + unsigned long ____addr; \
> __set_fixmap(idx, phys, flags); \
> - addr = fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1)); \
> - addr; \
> + ____addr = fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1)); \
> + ____addr; \
> })
>
> #define set_fixmap_offset(idx, phys) \
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-10-12 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 8:08 [RFC] fixmap: change temp variable name yalin wang
2015-10-12 9:05 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1510121104180.6097@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox