From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [patch 10/20] cpu/hotplug: Make target state writeable Date: Mon, 29 Feb 2016 16:49:24 +0100 (CET) Message-ID: References: <20160226164321.657646833@linutronix.de> <6355023.m2RKuauZef@vostro.rjw.lan> <1490843.2y32Taz9fS@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.linutronix.de ([62.245.132.108]:41230 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbcB2PvD (ORCPT ); Mon, 29 Feb 2016 10:51:03 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Rafael J. Wysocki" Cc: LKML , Linus Torvalds , Andrew Morton , Ingo Molnar , Peter Zijlstra , Peter Anvin , Oleg Nesterov , linux-arch@vger.kernel.org, Tejun Heo , Steven Rostedt , Rusty Russell , Paul McKenney , Rafael Wysocki , Arjan van de Ven , Rik van Riel , "Srivatsa S. Bhat" , Sebastian Siewior , Paul Turner On Sun, 28 Feb 2016, Thomas Gleixner wrote: > > Understood. I'll fix that thing up so that won't happen and I put it on the > list of things to look at deeper. The below delta patch should do what you need, right? Thanks, tglx 8<------------- --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1461,6 +1461,11 @@ static ssize_t write_cpuhp_target(struct if (target != CPUHP_OFFLINE && target != CPUHP_ONLINE) return -EINVAL; #endif + + ret = lock_device_hotplug_sysfs(); + if (ret) + return ret; + mutex_lock(&cpuhp_state_mutex); sp = cpuhp_get_step(target); ret = !sp->name || sp->cant_stop ? -EINVAL : 0; @@ -1472,6 +1477,8 @@ static ssize_t write_cpuhp_target(struct ret = do_cpu_up(dev->id, target); else ret = do_cpu_down(dev->id, target); + + unlock_device_hotplug(); return ret ? ret : count; }