From: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Oleg Nesterov <oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
Cc: Roland McGrath <roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Martin Schwidefsky
<schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING
Date: Tue, 8 Apr 2008 07:53:15 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0804080748320.2886@woody.linux-foundation.org> (raw)
In-Reply-To: <20080408113519.GA227-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
On Tue, 8 Apr 2008, Oleg Nesterov wrote:
>
> We only need this flag as an implicit parameter to the arch dependent do_signal()
> which we can't call directly, and thus it must imply TIF_SIGPENDING, and it
> is not valid after do_signal() (should be cleared). This all looks like
> ERESTART_ magic, why should we add something else ?
I think you're right. I didn't look at the actual code-paths, but my gut
feel says "yes, TIF_RESTORE_SIGMASK should actually have been
-ERESTARTSIGRESTORE". That sounds like the right thing to do.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING
Date: Tue, 8 Apr 2008 07:53:15 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0804080748320.2886@woody.linux-foundation.org> (raw)
Message-ID: <20080408145315.FWeNzQ2KWgF8-YCHSOA53LASPyx3Hh2xpwbRdj_jitU@z> (raw)
In-Reply-To: <20080408113519.GA227@tv-sign.ru>
On Tue, 8 Apr 2008, Oleg Nesterov wrote:
>
> We only need this flag as an implicit parameter to the arch dependent do_signal()
> which we can't call directly, and thus it must imply TIF_SIGPENDING, and it
> is not valid after do_signal() (should be cleared). This all looks like
> ERESTART_ magic, why should we add something else ?
I think you're right. I didn't look at the actual code-paths, but my gut
feel says "yes, TIF_RESTORE_SIGMASK should actually have been
-ERESTARTSIGRESTORE". That sounds like the right thing to do.
Linus
next prev parent reply other threads:[~2008-04-08 14:53 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 0:12 [PATCH 1/4] set_restore_sigmask Roland McGrath
2008-03-29 0:12 ` Roland McGrath
[not found] ` <20080329001230.D013726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 0:13 ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Roland McGrath
2008-03-29 0:13 ` Roland McGrath
[not found] ` <20080329001341.7F93826FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 0:53 ` Linus Torvalds
2008-03-29 0:53 ` Linus Torvalds
[not found] ` <alpine.LFD.1.00.0803281746480.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29 2:24 ` Roland McGrath
2008-03-29 2:24 ` Roland McGrath
2008-03-29 2:52 ` Linus Torvalds
2008-03-29 2:52 ` Linus Torvalds
[not found] ` <alpine.LFD.1.00.0803281942440.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29 3:12 ` Roland McGrath
2008-03-29 3:12 ` Roland McGrath
[not found] ` <20080329022408.0DD4726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 3:11 ` [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK Roland McGrath
2008-03-29 3:11 ` Roland McGrath
2008-04-09 11:45 ` David Woodhouse
2008-04-09 11:45 ` David Woodhouse
2008-04-10 20:32 ` Russell King
2008-04-10 20:32 ` Russell King
[not found] ` <20080410203250.GA21589-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-04-11 13:40 ` David Woodhouse
2008-04-11 13:40 ` David Woodhouse
2008-03-29 3:14 ` Roland McGrath
2008-03-29 3:14 ` Roland McGrath
2008-03-29 3:14 ` [PATCH 2/2] x86 TS_RESTORE_SIGMASK Roland McGrath
2008-03-29 3:14 ` Roland McGrath
2008-03-31 13:01 ` Ingo Molnar
2008-03-31 13:01 ` Ingo Molnar
2008-03-31 19:30 ` Roland McGrath
2008-03-31 19:30 ` Roland McGrath
2008-03-30 10:53 ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Paul Mackerras
2008-03-30 10:53 ` Paul Mackerras
2008-04-08 11:35 ` Oleg Nesterov
2008-04-08 11:35 ` Oleg Nesterov
[not found] ` <20080408113519.GA227-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-08 14:53 ` Linus Torvalds [this message]
2008-04-08 14:53 ` Linus Torvalds
2008-04-08 19:51 ` Roland McGrath
2008-04-08 19:51 ` Roland McGrath
2008-04-09 11:16 ` David Woodhouse
2008-04-09 11:16 ` David Woodhouse
[not found] ` <1207739787.27048.57.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2008-04-09 11:39 ` Oleg Nesterov
2008-04-09 11:39 ` Oleg Nesterov
2008-04-09 12:57 ` Petr Tesarik
2008-04-09 12:57 ` Petr Tesarik
[not found] ` <20080409113939.GA99-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-09 16:14 ` David Woodhouse
2008-04-09 16:14 ` David Woodhouse
2008-04-09 16:22 ` Oleg Nesterov
2008-04-09 16:22 ` Oleg Nesterov
2008-04-09 18:40 ` David Woodhouse
2008-04-09 18:40 ` David Woodhouse
2008-03-29 0:14 ` [PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK Roland McGrath
2008-03-29 0:14 ` Roland McGrath
2008-03-31 7:53 ` Martin Schwidefsky
2008-03-31 7:53 ` Martin Schwidefsky
2008-03-29 0:14 ` [PATCH 4/4] ia64 " Roland McGrath
2008-03-29 0:14 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0804080748320.2886@woody.linux-foundation.org \
--to=torvalds-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org \
--cc=roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox