From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Date: Tue, 8 Apr 2008 07:53:15 -0700 (PDT) Message-ID: References: <20080329001230.D013726FA1D@magilla.localdomain> <20080329001341.7F93826FA1D@magilla.localdomain> <20080408113519.GA227@tv-sign.ru> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <20080408113519.GA227-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Oleg Nesterov Cc: Roland McGrath , Andrew Morton , Martin Schwidefsky , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Tue, 8 Apr 2008, Oleg Nesterov wrote: > > We only need this flag as an implicit parameter to the arch dependent do_signal() > which we can't call directly, and thus it must imply TIF_SIGPENDING, and it > is not valid after do_signal() (should be cleared). This all looks like > ERESTART_ magic, why should we add something else ? I think you're right. I didn't look at the actual code-paths, but my gut feel says "yes, TIF_RESTORE_SIGMASK should actually have been -ERESTARTSIGRESTORE". That sounds like the right thing to do. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:42193 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752527AbYDHOyL (ORCPT ); Tue, 8 Apr 2008 10:54:11 -0400 Date: Tue, 8 Apr 2008 07:53:15 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING In-Reply-To: <20080408113519.GA227@tv-sign.ru> Message-ID: References: <20080329001230.D013726FA1D@magilla.localdomain> <20080329001341.7F93826FA1D@magilla.localdomain> <20080408113519.GA227@tv-sign.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: Oleg Nesterov Cc: Roland McGrath , Andrew Morton , Martin Schwidefsky , linux-s390@vger.kernel.org, tony.luck@intel.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20080408145315.FWeNzQ2KWgF8-YCHSOA53LASPyx3Hh2xpwbRdj_jitU@z> On Tue, 8 Apr 2008, Oleg Nesterov wrote: > > We only need this flag as an implicit parameter to the arch dependent do_signal() > which we can't call directly, and thus it must imply TIF_SIGPENDING, and it > is not valid after do_signal() (should be cleared). This all looks like > ERESTART_ magic, why should we add something else ? I think you're right. I didn't look at the actual code-paths, but my gut feel says "yes, TIF_RESTORE_SIGMASK should actually have been -ERESTARTSIGRESTORE". That sounds like the right thing to do. Linus