From: Linus Torvalds <torvalds@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-arch@vger.kernel.org,
Parisc List <linux-parisc@vger.kernel.org>,
linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Correct printk %pF to work on all architectures
Date: Wed, 3 Sep 2008 14:22:36 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0809031419560.3515@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1220473137.3254.29.camel@localhost.localdomain>
On Wed, 3 Sep 2008, James Bottomley wrote:
>
> Make dereference_function_descriptor() more accommodating by allowing
> architecture overrides.
Don't do it like this.
We don't want some stupid useless weak function that is empty on all sane
platforms.
Just do
.. declare or create an inline 'parisc_function_descriptor()' ..
#define dereference_function_descriptor(p) parisc_function_descriptor(p)
in some arch header file. And then use
#ifndef dereference_function_descriptor
#define dereference_function_descriptor(p) (p)
#endif
in the generic code, so that sane architectures don't need to do anything
at all.
Linus
next prev parent reply other threads:[~2008-09-03 21:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 20:18 [PATCH] Correct printk %pF to work on all architectures James Bottomley
2008-09-03 20:18 ` James Bottomley
2008-09-03 21:22 ` Linus Torvalds [this message]
2008-09-03 21:22 ` Linus Torvalds
2008-09-03 22:42 ` James Bottomley
2008-09-03 22:42 ` James Bottomley
2008-09-03 22:54 ` Linus Torvalds
2008-09-03 23:00 ` James Bottomley
2008-09-03 23:00 ` James Bottomley
2008-09-03 23:15 ` Linus Torvalds
2008-09-03 23:33 ` James Bottomley
2008-09-03 23:33 ` James Bottomley
2008-09-04 0:01 ` Linus Torvalds
2008-09-04 0:01 ` Linus Torvalds
2008-09-04 1:43 ` James Bottomley
2008-09-04 22:36 ` Benjamin Herrenschmidt
2008-09-04 22:36 ` Benjamin Herrenschmidt
2008-09-04 23:07 ` Luck, Tony
2008-09-04 23:07 ` Luck, Tony
2008-09-09 14:12 ` James Bottomley
2008-09-09 14:12 ` James Bottomley
2008-09-09 18:08 ` Kyle McMartin
2008-09-09 22:05 ` Benjamin Herrenschmidt
2008-09-09 22:05 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0809031419560.3515@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox