From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] Correct printk %pF to work on all architectures Date: Wed, 3 Sep 2008 14:22:36 -0700 (PDT) Message-ID: References: <1220473137.3254.29.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1220473137.3254.29.camel@localhost.localdomain> Sender: linux-ia64-owner@vger.kernel.org To: James Bottomley Cc: linux-arch@vger.kernel.org, Parisc List , linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: linux-arch.vger.kernel.org On Wed, 3 Sep 2008, James Bottomley wrote: > > Make dereference_function_descriptor() more accommodating by allowing > architecture overrides. Don't do it like this. We don't want some stupid useless weak function that is empty on all sane platforms. Just do .. declare or create an inline 'parisc_function_descriptor()' .. #define dereference_function_descriptor(p) parisc_function_descriptor(p) in some arch header file. And then use #ifndef dereference_function_descriptor #define dereference_function_descriptor(p) (p) #endif in the generic code, so that sane architectures don't need to do anything at all. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:54679 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbYICVXR (ORCPT ); Wed, 3 Sep 2008 17:23:17 -0400 Date: Wed, 3 Sep 2008 14:22:36 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH] Correct printk %pF to work on all architectures In-Reply-To: <1220473137.3254.29.camel@localhost.localdomain> Message-ID: References: <1220473137.3254.29.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Bottomley Cc: linux-arch@vger.kernel.org, Parisc List , linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org Message-ID: <20080903212236.ARUXD0MZL8vDDI5Intvb1g7ZBgW2IghgWefmQMdzk0M@z> On Wed, 3 Sep 2008, James Bottomley wrote: > > Make dereference_function_descriptor() more accommodating by allowing > architecture overrides. Don't do it like this. We don't want some stupid useless weak function that is empty on all sane platforms. Just do .. declare or create an inline 'parisc_function_descriptor()' .. #define dereference_function_descriptor(p) parisc_function_descriptor(p) in some arch header file. And then use #ifndef dereference_function_descriptor #define dereference_function_descriptor(p) (p) #endif in the generic code, so that sane architectures don't need to do anything at all. Linus