From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [patch 1/2] genirq: Run irq handlers with interrupts disabled Date: Fri, 2 Apr 2010 22:42:51 +0200 (CEST) Message-ID: References: <20100326000325.917127328@linutronix.de> <20100326000405.758579387@linutronix.de> <20100326061310.GV20695@one.firstfloor.org> <20100330053325.GL20695@one.firstfloor.org> <20100402093132.GA1360@ucw.cz> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.tglx.de ([62.245.132.106]:60325 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754561Ab0DBUpU (ORCPT ); Fri, 2 Apr 2010 16:45:20 -0400 In-Reply-To: <20100402093132.GA1360@ucw.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Pavel Machek Cc: Andi Kleen , Linus Torvalds , LKML , linux-arch@vger.kernel.org, Andrew Morton , Ingo Molnar , Peter Zijlstra , Alan Cox , David Miller , Greg Kroah-Hartman , Arnaldo Carvalho de Melo On Fri, 2 Apr 2010, Pavel Machek wrote: > On Wed 2010-03-31 13:16:37, Thomas Gleixner wrote: > > On Tue, 30 Mar 2010, Andi Kleen wrote: > > > > > > Why not simply force IRQF_DISABLED for all MSI interrupts. That still > > > > allows nesting for non MSI ones, but it limits the chance of throwing > > > > up reasonably well. That's a two liner. > > > > > > > > Can you please test whether it resolves the issue at hand ? > > > > > > Sorry for the late answer. Got confirmation that this patch > > > fixes the test case. Thanks. > > > > Ok, I'll push it linus wards and cc stable. I think thats the least > > intrusive safe bet we can have right now. > > stable? I'd say thats way too intrusive for -stable... So we better let the possible stack overruns unaddressed ? Thanks, tglx