RE: [PATCHv1 000/211] unicore32 architecture support

Thomas Gleixner
2010-12-10T11:02:03Z

On Fri, 10 Dec 2010, Guan Xuetao wrote:
>
> > -----Original Message-----
> > From: linux-arch-owner@vger.kernel.org [mailto:linux-arch-
> > owner@vger.kernel.org] On Behalf Of Thomas Gleixner
> > Sent: Thursday, December 09, 2010 9:50 PM
> > To: Tejun Heo
> > Cc: Guan Xuetao; Arnd Bergmann; linux-arch@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCHv1 000/211] unicore32 architecture support

Please fix your mail client to do proper citations. A single line

On Thu, 9 Dec 2010, Thomas Gleixner wrote:

or whatever your preferred cite line is, is sufficient. We all have
the mail header already.

> > It's ok to have several patches ordered by topics
> >
> > - generic header stuff
> > - processor and system headers
> > - low level entry and setup code
> > - process/thread related code
> > - mm related code
> > - timers
> > - interrupts
> > - ptrace
> > - signals
> > - fault handling
> > - misc
> > - build system, main makefile, Kconfig
> >
> > That makes it actually feasible to review.
> Thanks,
> I will rearrange my patches.

And please mail them to yourself before you post them and make sure
they apply and resemble exaclty what you wanted to send. I just
noticed, that your mailer line-wrapped the patches:

+ /*
+ * actually the registers should be pushed and pop'd conditionally,
but
+ * after bl the flags are certainly clobbered
+ */

Thanks,

tglx