RE: [patch v3 24/36] Hexagon: Provide basic implementation and/or stubs for I/O routines.

Benjamin Herrenschmidt
2011-09-11T14:46:55Z

On Sat, 2011-09-10 at 15:02 -0500, Taylor Simpson wrote:
> Using "memory" is a pretty big hammer. Wouldn't it be better to use a
> memory operand?
> asm volatile(
> "memb(%0) = %1;"
> : "m" (*(u8*)addr)
> : "r" (data)
> );

No you probably really want a full "memory" clobber, because typically
your IO ops should also act as barriers. The compiler has no way to know
for example that you want to order previous stores to memory (some DMA
descriptor you are populating) vs. an MMIO access that will trigger the
DMA from that location.

Linux defines the readX/writeX accessors as being fully ordered in that
case.

In fact, I'm not familiar with Hexagon, but if it's a weakly ordered
memory model you may also need some kind of memory barrier in those
accessors.

Cheers,
Ben.

> This may be a dumb question, but why do we need inline asm? Why can't we
> write this with plain C code?
> /*
> * writeb - write a byte to a memory location
> * @data: data to write to
> * @addr: pointer to memory
> *
> */
> static inline void writeb(u8 data, volatile void __iomem *addr) {
> volatile u8 *ptr = (volatile u8*)addr;
> *ptr = data;
> }
>
>
> Taylor
>
>
>
> -----Original Message-----
> From: linux-hexagon-owner@vger.kernel.org
> [mailto:linux-hexagon-owner@vger.kernel.org] On Behalf Of Arnd Bergmann
> Sent: Friday, September 09, 2011 4:13 PM
> To: Linas Vepstas (Code Aurora)
> Cc: Richard Kuo; linux-arch@vger.kernel.org; linux-hexagon@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [patch v3 24/36] Hexagon: Provide basic implementation and/or
> stubs for I/O routines.
>
> On Friday 09 September 2011 14:14:13 Linas Vepstas wrote:
> > On Thu, Sep 08, 2011 at 08:09:11PM -0500, Richard Kuo wrote:
> > > + asm volatile(
> > > + "memb(%0) = %1;"
> > > + :
> > > + : "r" (addr), "r" (data)
> > > + );
> >
> > I'm kind-of vague on this, but I think that this also needs a
> > : "memory" at the end (to indicate that the asm snippet clobbers
> > memory), as otherwise the compiler may be tempted to reorder
> > these around other memory accesses. That is, the "volatile"
> > keyword is not enough (well, I'm not sure...), but I think
> > "volatile" only prevents the compiler from optimizing these
> > away completely, but is not enough to prevent unwanted
> > re-ordering.
>
> Yes, absolutely correct. Specifically, this is required for the
> case where you first store values into regular memory and then
> use the writel() to trigger a DMA operation. Without the memory
> clobber, the dma may read from memory before the CPU has accessed
> it in case the store gets scheduled after the writel by the compiler.
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/