Re: [patch v3 21/36] Hexagon: Add SMP support

Richard Kuo
2011-09-12T23:38:30Z

On Sun, Sep 11, 2011 at 11:51:52AM -0300, Benjamin Herrenschmidt wrote:
> And on the producer side, a spinlock for one or... that looks like wheel
> re-inventing to me :-)
>
> In fact your bit iteration loop also re-invents find_*_bit interfaces.
>
> Any reason why you don't simply use bitops or atomics here ?

No particular reason; just the way it turned out when I was getting things
working. I'll get them cleaned up.

> Also what is your memory model ? ordered or weakly ordered ? Do you need
> some kind of memory barrier between setting ipi->bits and
> __vmintop_post() ?

Our model is ordered, so there's no need for a barrier there yet.

Thanks,
Richard Kuo