Re: [patch v3 24/36] Hexagon: Provide basic implementation and/or stubs for I/O routines.

Linas Vepstas (Code Aurora)
2011-09-09T19:14:19Z

On Thu, Sep 08, 2011 at 08:09:11PM -0500, Richard Kuo wrote:
> + asm volatile(
> + "memb(%0) = %1;"
> + :
> + : "r" (addr), "r" (data)
> + );

I'm kind-of vague on this, but I think that this also needs a
: "memory" at the end (to indicate that the asm snippet clobbers
memory), as otherwise the compiler may be tempted to reorder
these around other memory accesses. That is, the "volatile"
keyword is not enough (well, I'm not sure...), but I think
"volatile" only prevents the compiler from optimizing these
away completely, but is not enough to prevent unwanted
re-ordering.

--linas