From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v4 18/36] Hexagon: Add time and timer functions Date: Mon, 19 Sep 2011 15:38:02 +0200 (CEST) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-hexagon-owner@vger.kernel.org To: Richard Kuo Cc: linux-arch@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Wed, 14 Sep 2011, Richard Kuo wrote: > + > +void debug_adsp_timers(void) > +{ > + printk(KERN_INFO "rtos_timer->match=0x%08x\n", rtos_timer->match); > + printk(KERN_INFO "rtos_timer->count=%d\n", rtos_timer->count); > + printk(KERN_INFO "rtos_timer->enable=%d\n", rtos_timer->enable); > + printk(KERN_INFO "rtos_timer->clear=%d\n", rtos_timer->clear); > +} Does this have a caller and is it useful ? Otherwise this looks good. Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from www.linutronix.de ([62.245.132.108]:55859 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753934Ab1ISNiF (ORCPT ); Mon, 19 Sep 2011 09:38:05 -0400 Date: Mon, 19 Sep 2011 15:38:02 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH v4 18/36] Hexagon: Add time and timer functions In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Kuo Cc: linux-arch@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20110919133802.A2zVawEkC2d_s7D4bBgwfBz6WSmZedVUeo6IfAz788M@z> On Wed, 14 Sep 2011, Richard Kuo wrote: > + > +void debug_adsp_timers(void) > +{ > + printk(KERN_INFO "rtos_timer->match=0x%08x\n", rtos_timer->match); > + printk(KERN_INFO "rtos_timer->count=%d\n", rtos_timer->count); > + printk(KERN_INFO "rtos_timer->enable=%d\n", rtos_timer->enable); > + printk(KERN_INFO "rtos_timer->clear=%d\n", rtos_timer->clear); > +} Does this have a caller and is it useful ? Otherwise this looks good. Reviewed-by: Thomas Gleixner