From: Thomas Gleixner <tglx@linutronix.de>
To: Kevin Hilman <khilman@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [patch 08/34] arm: Use generic idle loop
Date: Mon, 25 Mar 2013 12:31:20 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1303251230440.22263@ionos> (raw)
In-Reply-To: <87zjxv9lga.fsf@linaro.org>
On Fri, 22 Mar 2013, Kevin Hilman wrote:
> Hi Thomas,
>
> Thomas Gleixner <tglx@linutronix.de> writes:
>
> > Use the generic idle loop and replace enable/disable_hlt with the
> > respective core functions.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Russell King <linux@arm.linux.org.uk>
>
> I gave patches 1-5 + this a quick spin on ARM (specifially some OMAP3 and
> OMAP4 platforms, with and without CPUidle enabled.)
>
> The OMAP stuff needed a couple minor compile fixes (below), but
> otherwise it passes the quick "seems to work" test.
Yeah, that's needed for the other arch/arm conversions as well.
Thanks,
tglx
> So at least for ARM/OMAP:
>
> Tested-by: Kevin Hilman <khilman@linaro.org>
>
> Kevin
>
>
> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
> index 23c653a..db37f49 100644
> --- a/arch/arm/mach-omap1/pm.c
> +++ b/arch/arm/mach-omap1/pm.c
> @@ -43,6 +43,7 @@
> #include <linux/module.h>
> #include <linux/io.h>
> #include <linux/atomic.h>
> +#include <linux/cpu.h>
>
> #include <asm/fncpy.h>
> #include <asm/system_misc.h>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 3a6c6b8..2f17f95 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -138,6 +138,7 @@
> #include <linux/spinlock.h>
> #include <linux/slab.h>
> #include <linux/bootmem.h>
> +#include <linux/cpu.h>
>
> #include <asm/system_misc.h>
>
next prev parent reply other threads:[~2013-03-25 11:31 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 21:52 [patch 00/34] idle: Consolidate idle implementations Thomas Gleixner
2013-03-21 21:52 ` [patch 01/34] arch: Cleanup enable/disable_hlt Thomas Gleixner
2013-03-21 21:52 ` Thomas Gleixner
2013-03-21 21:52 ` [patch 02/34] arch: Consolidate tsk_is_polling() Thomas Gleixner
2013-03-21 21:52 ` Thomas Gleixner
2013-03-22 5:01 ` Tony Breeds
2013-03-22 5:20 ` Tony Breeds
2013-03-22 9:26 ` Thomas Gleixner
2013-03-21 21:52 ` [patch 03/34] idle: Implement set/clr functions for need_resched poll Thomas Gleixner
2013-03-21 21:52 ` Thomas Gleixner
2013-03-22 9:38 ` James Hogan
2013-03-21 21:52 ` [patch 04/34] idle: Provide a generic entry point for the idle code Thomas Gleixner
2013-03-21 21:52 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 05/34] idle: Implement generic idle function Thomas Gleixner
2013-03-23 8:56 ` Heiko Carstens
2013-03-25 10:39 ` Thomas Gleixner
2013-03-28 15:39 ` Srivatsa S. Bhat
2013-11-18 6:05 ` Viresh Kumar
2013-11-22 22:32 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 06/34] arc: Use generic idle loop Thomas Gleixner
2013-03-22 9:02 ` Vineet Gupta
2013-03-21 21:53 ` [patch 07/34] alpha: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:37 ` Srivatsa S. Bhat
2013-03-29 11:22 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 08/34] arm: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-22 21:24 ` Kevin Hilman
2013-03-22 21:24 ` Kevin Hilman
2013-03-25 11:31 ` Thomas Gleixner [this message]
2013-03-25 11:48 ` Russell King - ARM Linux
2013-03-25 11:48 ` Russell King - ARM Linux
2013-03-25 14:02 ` Thomas Gleixner
2013-04-08 21:47 ` Russell King - ARM Linux
2013-04-09 9:20 ` Thomas Gleixner
2013-04-09 9:20 ` Thomas Gleixner
2013-04-09 9:38 ` Russell King - ARM Linux
2013-04-09 9:38 ` Russell King - ARM Linux
2013-04-25 20:03 ` Stephen Boyd
2013-04-25 21:01 ` Thomas Gleixner
2013-04-25 21:01 ` Thomas Gleixner
2013-05-01 0:49 ` Stephen Boyd
2013-05-01 0:55 ` Paul E. McKenney
2013-05-21 0:57 ` [PATCH] ARM: smp: Drop RCU_NONIDLE usage in cpu_die() Stephen Boyd
2013-03-21 21:53 ` [patch 09/34] arm64: Use generic idle loop Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-25 18:06 ` Catalin Marinas
2013-03-21 21:53 ` [patch 10/34] avr32: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 11/34] bfin: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 12/34] c6x: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 13/34] cris: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-27 15:04 ` Jesper Nilsson
2013-03-27 15:04 ` Jesper Nilsson
2013-03-27 17:10 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 14/34] frv: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 15/34] h8300: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 16/34] hexagon: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 17/34] ia64: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:40 ` Srivatsa S. Bhat
2013-03-28 15:40 ` Srivatsa S. Bhat
2013-03-21 21:53 ` [patch 18/34] m32r: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 19/34] m68k: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 20/34] metag: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-22 10:16 ` James Hogan
2013-03-25 11:26 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 21/34] microblaze: " Thomas Gleixner
2013-03-21 21:53 ` [patch 22/34] mips: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:42 ` Srivatsa S. Bhat
2013-03-28 15:42 ` Srivatsa S. Bhat
2013-03-21 21:53 ` [patch 24/34] openrisc: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 23/34] mn10300: " Thomas Gleixner
2013-03-21 21:53 ` [patch 25/34] parisc: " Thomas Gleixner
2013-03-21 21:53 ` [patch 26/34] powerpc: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:40 ` Srivatsa S. Bhat
2013-03-28 15:40 ` Srivatsa S. Bhat
2013-04-01 9:13 ` Deepthi Dharwar
2013-04-01 9:13 ` Deepthi Dharwar
2013-03-21 21:53 ` [patch 27/34] s390: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-23 9:38 ` Heiko Carstens
2013-03-23 9:38 ` Heiko Carstens
2013-03-23 9:39 ` Heiko Carstens
2013-03-21 21:53 ` [patch 28/34] score: " Thomas Gleixner
2013-03-21 21:53 ` [patch 29/34] sh: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:40 ` Srivatsa S. Bhat
2013-03-21 21:53 ` [patch 30/34] tile: Enter idle with preemption disabled Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-22 20:34 ` Chris Metcalf
2013-03-22 20:40 ` Chris Metcalf
2013-03-28 15:43 ` Srivatsa S. Bhat
2013-03-28 15:43 ` Srivatsa S. Bhat
2013-03-21 21:53 ` [patch 31/34] tile: Use generic idle loop Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:41 ` Srivatsa S. Bhat
2013-03-29 11:24 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 32/34] unicore: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-21 21:53 ` [patch 33/34] x86: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-28 15:43 ` Srivatsa S. Bhat
2013-03-28 15:43 ` Srivatsa S. Bhat
2013-03-21 21:53 ` [patch 34/34] xtensa: " Thomas Gleixner
2013-03-21 21:53 ` Thomas Gleixner
2013-03-22 12:37 ` Max Filippov
2013-03-22 12:37 ` Max Filippov
2013-03-22 20:09 ` [patch 00/34] idle: Consolidate idle implementations Sam Ravnborg
[not found] ` <alpine.LFD.2.02.1303271940150.22263@ionos>
[not found] ` <5153EC43.7070808@zankel.net>
2013-03-28 9:24 ` Thomas Gleixner
2013-03-28 22:16 ` Chris Zankel
2013-03-29 16:19 ` Sam Ravnborg
2013-03-29 16:19 ` Sam Ravnborg
2013-03-29 20:29 ` [PATCH] sparc: Use generic idle loop Sam Ravnborg
2013-03-31 23:46 ` David Miller
2013-04-01 6:53 ` Srivatsa S. Bhat
2013-04-01 6:53 ` Srivatsa S. Bhat
2013-04-01 9:06 ` Sam Ravnborg
2013-04-01 9:06 ` Sam Ravnborg
2013-04-08 12:33 ` Srivatsa S. Bhat
2013-04-08 12:33 ` Srivatsa S. Bhat
2013-04-08 17:10 ` Sam Ravnborg
2013-04-08 19:24 ` David Miller
2013-04-11 19:38 ` [PATCH v2] " Sam Ravnborg
2013-04-11 19:38 ` Sam Ravnborg
2013-04-12 18:56 ` Thomas Gleixner
2013-04-12 18:58 ` David Miller
2013-05-03 9:47 ` [patch 00/34] idle: Consolidate idle implementations Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1303251230440.22263@ionos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=khilman@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).