From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH v17 05/10] fs,landlock: Support filesystem access-control Date: Fri, 15 May 2020 03:31:38 +1000 (AEST) Message-ID: References: <20200511192156.1618284-1-mic@digikod.net> <20200511192156.1618284-6-mic@digikod.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1665246916-621977297-1589477498=:26489" Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: To: =?ISO-8859-15?Q?Micka=EBl_Sala=FCn?= Cc: Casey Schaufler , linux-kernel@vger.kernel.org, Al Viro , Andy Lutomirski , Arnd Bergmann , Jann Horn , Jonathan Corbet , Kees Cook , Michael Kerrisk , =?ISO-8859-15?Q?Micka=EBl_Sala=FCn?= , "Serge E . Hallyn" , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org List-Id: linux-arch.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1665246916-621977297-1589477498=:26489 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 14 May 2020, Mickaël Salaün wrote: > > This needs to be converted to the LSM API via superblock blob stacking. > > > > See Casey's old patch: > > https://lore.kernel.org/linux-security-module/20190829232935.7099-2-casey@schaufler-ca.com/ > > s_landlock_inode_refs is quite similar to s_fsnotify_inode_refs, but I > can do it once the superblock security blob patch is upstream. Is it a > blocker for now? What is the current status of lbs_superblock? Yes it is a blocker. Landlock should not be adding its own functions in core code, it should be using the LSM API (and extending that as needed). > Anyway, we also need to have a call to landlock_release_inodes() in > generic_shutdown_super(), which does not fit the LSM framework, and I > think it is not an issue. Landlock handling of inodes is quite similar > to fsnotify. fsnotify is not an LSM. -- James Morris --1665246916-621977297-1589477498=:26489-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from namei.org ([65.99.196.166]:59018 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbgENRcP (ORCPT ); Thu, 14 May 2020 13:32:15 -0400 Date: Fri, 15 May 2020 03:31:38 +1000 (AEST) From: James Morris Subject: Re: [PATCH v17 05/10] fs,landlock: Support filesystem access-control In-Reply-To: Message-ID: References: <20200511192156.1618284-1-mic@digikod.net> <20200511192156.1618284-6-mic@digikod.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1665246916-621977297-1589477498=:26489" Sender: linux-arch-owner@vger.kernel.org List-ID: To: =?ISO-8859-15?Q?Micka=EBl_Sala=FCn?= Cc: Casey Schaufler , linux-kernel@vger.kernel.org, Al Viro , Andy Lutomirski , Arnd Bergmann , Jann Horn , Jonathan Corbet , Kees Cook , Michael Kerrisk , =?ISO-8859-15?Q?Micka=EBl_Sala=FCn?= , "Serge E . Hallyn" , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org Message-ID: <20200514173138.5Oz0gw9pTUh8L4oOjMJ5CD4fogfy_wOhvFZpaO6lbpk@z> This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1665246916-621977297-1589477498=:26489 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 14 May 2020, Mickaël Salaün wrote: > > This needs to be converted to the LSM API via superblock blob stacking. > > > > See Casey's old patch: > > https://lore.kernel.org/linux-security-module/20190829232935.7099-2-casey@schaufler-ca.com/ > > s_landlock_inode_refs is quite similar to s_fsnotify_inode_refs, but I > can do it once the superblock security blob patch is upstream. Is it a > blocker for now? What is the current status of lbs_superblock? Yes it is a blocker. Landlock should not be adding its own functions in core code, it should be using the LSM API (and extending that as needed). > Anyway, we also need to have a call to landlock_release_inodes() in > generic_shutdown_super(), which does not fit the LSM framework, and I > think it is not an issue. Landlock handling of inodes is quite similar > to fsnotify. fsnotify is not an LSM. -- James Morris --1665246916-621977297-1589477498=:26489--