From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209635; b=p2wYCQvLxuiUqPyqp9HovxfuNlmdWhJ4GIsY7sU4RgT4J7rHUp32txxu93WlEi7P5dkb /YqH3bG9difCNTWSO0MzFcG/6tk5K6K8T3pJ5LpSIytC1xjGkiFXeuqFl03mSgXzrXFIt YfZ7WxwurULfJ+kmb3T6pu/tx8f5+7ZzgEadPbFey935f+ecS5ZLQWz2GkT7a7ncmgzgW NqjPk/TGb/x3ta5Dv8UnD+NdalbaSB/2kFbydTFyAv0BXViovw+EPr0aTkp5XK5FfNu/D gJ4BoPCfsreR6xnVSlqjT/UHeRwNs5dAICiHYpNOeVYCyhi8BYzhiIsEotcH2FvBWrw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209635; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=uwc/8l7ROwnSyuFNhcqYS+argc0ih61o4NRO02Y73ve9H6Bz2QnSO1XL6UcSXqyZpaYv 09GiHn+xvKA5Ri2wBcwgQv2KdIPcPkFMeIQVsLyHiwFPvvLgU+FAuFuTT+4vyv/psfoof qSCr3B/+ZY7ybmKJ76S11acI1VoBJPToINDqQPrBOyg23WzzFVDId2h9FYQPylRBCdLjM pxTHQYhvJEiMGuQBm9IGtUS/yJZbKzvX/TB4u7D0ZQqEDm97C8vD3+P0BmSD93jJJNe6S MIhv5pBSDZqMYzfqTgr9EV1uUiDP4/As5bVe0+ompP9kyH55SE9eTMLcPwZiEnVys8w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=TD1Tphal; arc=none smtp.remote-ip=209.85.221.171 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300C2606A321 for ; Wed, 28 Oct 2026 17:47:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 300C2606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=TD1Tphal Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-5eac7220e9cso565659e0c.3 for ; Wed, 28 Oct 2026 10:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793209634; x=1793814434; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=TD1Tphal9MmPmFW1OAcHF/1klWnZxSWsLxd9CIm64eCSWcLG7mG8zrPQ3838MtFr4w ZTKCFSl3LqqxJqx29pzfAWYQn1mEBphAMjxHQh2ZHPqCNzRbnJPKUjX2PRrurF12ETcu CqpI8q6ywMMFJMi3OCCZOyjdy4BmQdRRXzkxus9AfgMjqltqf3IgwcGXKdaAfyNZJuvk HngFug3/3BeoVvKeVjohQauw+bz3WMJQ37zeQDc/5Xa08m9CibytH/i9Kqr3FZ0mRD9u xfZJ4xMidWmVes15PXyLTH2PjJtuANBfb2w8XVOA8lDU7YBkZu5NB+fyh6+p652P4J5j lCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793209634; x=1793814434; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=UMAvGjUrCQ8ygHpx47ZC3DzKlL2f1I/Ojg+tFmpzcVuMe/PodRq6A13ejudN5FLySo 1u8+iYfSS0LZgXFt/pc2E+/zhBSdC8Vk1dz9vrLIqhcPaRbx2U9Ksp0zTrZHv/R9ZfEr ShHsRkPjpNHzy5EYwgIo29xkTKoUqd9gV0IQ5KehbllaNBcx5n6gjYEKAJq8BSJbAIb5 61cXqD+DGhoyJS1eMxNv5t9O2YAgPDe4h830wEKbMnq9DQTkfLvvpCOFJRjDOWnHZBSD GI805vc+ahcC12CKg0HFJgX3L9uuurxzMXFsV8TFg0Qp6lAyERCyhjwuuK2pwO4XCKrB Pxaw== X-Forwarded-Encrypted: i=1; AKwUvBzhReRYv7zgE1IY9EgWxmTdjiq8Jbf8gm3+3t3ldz0xCvFNQB7ZPIC5p64u/rzjAaAmPkCmhzhVfdzX@vger.kernel.org X-Gm-Message-State: AFq9FYI6bysNNq7na39Ai5vsBR/hc7ZhDWjSf9YTvHqQ9vNPWQT5vHBO 85Y7pEAeWnqkJI6SCnfj/FNe0MhHtrF2ZE0FOb2nEGTalKgRRYV8YP2F2qxAzcAQCGA= X-Gm-Gg: AYBFou3zTtwKbar8b1pN1Sr/tXxt5kqCaGu16YEHZYvJwG1N8cK7pGT3I9J35cgCMHk W+P44yKzXAzeIogHAx+oV9jKKKtnWo2LevLmjujOyJHOfBhaz5Wvt6JNcQVnLtV7fmnGGZLe/Lt 1zhR9rPsV51SQVVoNjkjsZf5Y7p2AJKjO2bQ0kmUsbkyrC7/tkLmHdA7WSGFmrbDD+XK63Jjizr HVqlJG1p/IQs/qanYHccoaouNSChOhtjoyZb36jr0lj2vjJR0uz8zOKMO4JZmIuv9Lz4GD1iGw6 OfxS2EiZoZh+6gdV2n4PBwPsjEiyqJsHGwYlv6NTRSJS63P/libsppMzZ/WaccsKjJxpHQcOtFJ raJVwidkG89XR3AiU9aY1nqv8FDMZQvJ80Q9GUlxyzs9L/uZ/AwUbE5X8T2lU7VEij6bG/dyMOJ cJ9KWJMt04IL2UTeBOTaUEgvKsSmT/GeMeGB1LkIWtjDQ1BNKZyf5bmNzP5ypAr8getDrm2iT6F 1aNkhJD1bVEbM1U/HwjGtgoE1j7dl3eKkQ349W9lXZgoOu3ZwS4av7MD+R4NghqLWpOZ+/1UJ+I PgGDRbB20OQJnA4BWva8/glgDApKAlmW1Dy2gRHT0jfQg1+dEcjSskNvBcHF6Yk1hMO8DTBkjWH z+TK8v205qUlRj8rpLVmzYx3vrDxKjyAqNspYgh1z9RwTNR1NfRu5jQ== X-Received: by 2002:a05:6122:2896:b0:5ea:fae8:e69e with SMTP id 71dfb90a1353d-5ec4cc4f065mr1774474e0c.11.1793209634129; Wed, 28 Oct 2026 10:47:14 -0700 (PDT) Received: from google.com (64.167.245.35.bc.googleusercontent.com. [35.245.167.64]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5ec57e4e556sm445088e0c.5.2026.10.28.10.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:47:13 -0700 (PDT) Date: Wed, 28 Oct 2026 13:47:12 -0400 From: Pasha Tatashin To: David Matlack Cc: Pratyush Yadav , Pasha Tatashin , tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <2vxz8q3hoicx.fsf@kernel.org> X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 10-28 10:24, David Matlack wrote: > On Wed, Oct 28, 2026 at 10:17 AM Pratyush Yadav wrote: > > > > On Mon, Oct 26 2026, David Matlack wrote: > > > > > On 2026-10-25 04:38 PM, Pasha Tatashin wrote: > > >> On Fri, Oct 23, 2026 at 9:50 AM David Matlack wrote: > > > > > [...] > > >> The reason I care about keeping the header compact is that we are > > >> defining a foundational kernel ABI and want to use this header across > > >> almost every serialized data structure so we can evolve them later > > >> without breaking compatibility. While some top-level structs are on > > >> sparse folios today, other serialized structs are tightly packed, and > > >> we are looking to add KHO slab support in the future where tightly > > >> packed allocations will be common. > > > > > > My intuition is we will have a small number of headers per preserved > > > file and per preserved FLB. One for the top-level struct and then > > > optionally a few more for sub-structs like arch-specific data. That is > > > why I am less worried 8 bytes per header, even if we fix the folio > > > problem. > > > > > > Maybe where our visions differ is when there are collections of > > > serialized structs, like KHO blocks. For collections I don't think the > > > elements will each have their own headers. Otherwise the elements could > > > be different sizes. > > > > kho_block today doesn't store entry_size in the serialized payload. It > > relies on its caller to do so. With extensible structures, this can get > > messy. Sure, the owner of the kho_block_set can track the size somewhere > > in its payload, but perhaps we should store the size in > > kho_block_header_ser to begin with? > > +1000 > > KHO block should track the entry size automatically and not rely on > the caller. Otherwise every caller is going to have to store the entry > size in the struct that owns the KHO block, like I had to do in the > PCI v10 series :( I am fine with updating this as part of the versioning change so that we do not have to do it twice. Tarun, could you pelase include entry size change into the next version as well? Thanks, Pasha > > > Anyway, not a problem this series needs to solve, but something we > > should eventually do.