From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76EDC279334; Thu, 2 Apr 2026 04:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775102498; cv=none; b=I9AYs/rNRUjm8G7SQGdfGyyYD8mKpCeJ/oX3Yo3Q3374smYPTYYksq12CbIPAN/19DMSabZw5ZcxcaBLZtQkqq/tdAkig5Y9t+07ZjLsJJ4HkvLmlUsutSphA7Knp2mbxYEMOeTFNa9b3uUq9+MsSCRLxEJMZlIyugy/uxB8Uzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775102498; c=relaxed/simple; bh=tY3WvR4R/zrWI1MsWDPbn78x2fJshokN5D05V5yxYaM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kyq6IC5Meo7T4wB5s1PJidd54ECq/UK/hKgZzw0YdmV70xR6svfAlZrsRJUMbkrR4oIiXzn0DLFBSpcWOxp+icB3D68keIV5Xf9YDk7exngxGWG3Jm6cYn/dre5Ca+2rvgxNwVDRAsSMwtLtsbOE2/53iPbcqgHl2ZP3QKa5FEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=eAnUARNl; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="eAnUARNl" Received: from [10.95.66.83] (unknown [167.220.238.19]) by linux.microsoft.com (Postfix) with ESMTPSA id A6ED220B710C; Wed, 1 Apr 2026 21:01:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A6ED220B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775102490; bh=T6sBwsFb445Pp7249L79ufDRpJqZshHczUisxFI3JEo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eAnUARNlHoU7VXFylRE5DLFJrHd/bTFZfsva8Frd/0OaQNP+H5HBfDGUsKXcWK4j9 DCORtz3WkyAFjVZSBnLcBSqP1locZaGVeOkTYl3BxmW0xAd4W4kkTI8UTh5/aLonrY 7Rk51EmzcAbubl0WKZf4Ni57dSE1fX82drzW4uFo= Message-ID: Date: Thu, 2 Apr 2026 09:31:21 +0530 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] Drivers: hv: Add ARM64 support in mshv_vtl To: Michael Kelley , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Marc Zyngier , Timothy Hayes , Lorenzo Pieralisi , mrigendrachaubey , "ssengar@linux.microsoft.com" , "linux-hyperv@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-riscv@lists.infradead.org" References: <20260316121241.910764-1-namjain@linux.microsoft.com> Content-Language: en-US From: Naman Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/2026 10:24 PM, Michael Kelley wrote: > From: Naman Jain Sent: Tuesday, March 17, 2026 9:23 PM >> >> On 3/18/2026 3:33 AM, Michael Kelley wrote: >>> From: Naman Jain Sent: Monday, March 16, 2026 5:13 AM >>>> >>>> The series intends to add support for ARM64 to mshv_vtl driver. > > No need to be tentative. :-) Just write as: > > "The series adds support for ARM64 to the mshv_vtl driver." > >>>> For this, common Hyper-V code is refactored, necessary support is added, >>>> mshv_vtl_main.c is refactored and then finally support is added in >>>> Kconfig. >>>> >>>> Based on commit 1f318b96cc84 ("Linux 7.0-rc3") >>> >>> There's now an online LLM-based tool that is automatically reviewing >>> kernel patches. For this patch set, the results are here: >>> >>> https://sashiko.dev/#/patchset/20260316121241.910764-1-namjain%40linux.microsoft.com >>> >>> It has flagged several things that are worth checking, but I haven't >>> reviewed them to see if they are actually valid. >>> >>> FWIW, the announcement about sashiko.dev is here: >>> >>> https://lore.kernel.org/lkml/7ia4o6kmpj5s.fsf@castle.c.googlers.com/ >>> >>> Michael >> >> >> Thanks for sharing Michael, >> I'll check it out and do the needful. >> > > I've done a full review of this patch set and provided comments in the > individual patches. Some of my comments reference the Sashiko AI > comments, but there are still some Sashiko AI comments to consider > that I haven't referenced. > > FWIW, the Sashiko AI comments are quite good -- it found some things > here that I missed on my own, and in my earlier reviews of the original VTL > code. :-( > > Michael Thank you so much Michael for reviewing these. I was also trying to address review comments from Sashiko, and noticed some of them were false positives in the sense that these were existing issues and not introduced by arm64 changes. I thought of keeping them separate from the scope of this series for future. I'll review your comments and address them. Regards, Naman