From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [RFC PATCH v9 01/27] Documentation/x86: Add CET description Date: Thu, 06 Feb 2020 12:17:30 -0800 Message-ID: References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-2-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Randy Dunlap , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz List-Id: linux-arch.vger.kernel.org On Wed, 2020-02-05 at 16:16 -0800, Randy Dunlap wrote: > Hi, > > I have a few comments and a question (please see inline below). > > > On 2/5/20 10:19 AM, Yu-cheng Yu wrote: [...] > > +arch_prctl(ARCH_X86_CET_LOCK) > > + Lock in CET feature. > > which feature? Both SHSTK and IBT are locked. They cannot be turned off afterwards. I will check things you pointed out. Thanks, Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Subject: Re: [RFC PATCH v9 01/27] Documentation/x86: Add CET description From: Yu-cheng Yu Date: Thu, 06 Feb 2020 12:17:30 -0800 In-Reply-To: References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-2-yu-cheng.yu@intel.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org To: Randy Dunlap , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , x86-patch-review@intel.com List-ID: Message-ID: <20200206201730.RAg0MDK4ACcj5iXYjkp8knX4dQcp-OhpVKxl_cYRrUE@z> On Wed, 2020-02-05 at 16:16 -0800, Randy Dunlap wrote: > Hi, > > I have a few comments and a question (please see inline below). > > > On 2/5/20 10:19 AM, Yu-cheng Yu wrote: [...] > > +arch_prctl(ARCH_X86_CET_LOCK) > > + Lock in CET feature. > > which feature? Both SHSTK and IBT are locked. They cannot be turned off afterwards. I will check things you pointed out. Thanks, Yu-cheng