From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0A13BBED; Fri, 24 May 2024 18:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716575036; cv=none; b=Q/7OOyoezmwmJG5olvrVt3FMvHXdOX/HaxhBr/f4p/hxbE4zRnOjfOoFHKEf8HexFg8Z8ZI7MPtTMISRLF5XRy+qCsWM4ELZf4iQ/v2Qc5sbrzjEmj1MN8sbXmtOy36O6fAb4ttX6IVf6/UrvL6r7WYkvCQW2RpQJzgW0dSpz6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716575036; c=relaxed/simple; bh=h2h9Cj9giuSolJKbUGSLqFrF6LXIjIELBC4U7YGUsMk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hw38GDL/ueORwRuXO1Gy+HMUNLz05JJ6ZBUF1hIcJEdL5lf1Dj6XCYnwaccx1WArAULsB3u+12ETKXVbVsyo3gjx5/0cJ1jQgQOi7/diOULn+AaBJ7TF3wwxFOqrMkil2EQnGcicJMfY3SiNTXpSzoY7yFuGwR5nIbkdjVaw15E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q5Ad7HPz; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5Ad7HPz" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6f4ed9dc7beso2664939b3a.1; Fri, 24 May 2024 11:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716575034; x=1717179834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=iI5LPX8LqaFaVw1d3o/h8cFH5sAtkGM2Qf4ljWkA8MA=; b=Q5Ad7HPzJa+YTfzcjG7pfI7L6oF6PXUCLIEIO2VzS2kEs5QS5DYlZEh8wXAXPO9s9k kiEh/vXRoNQ8MIoB/wLsRz0mCFgnu8zYiaheh3nvcyXAYquNfwah+CTaEkmfAuGKiBfG s9NI1icbKn3mfK1BMCKcmOx9Aa5/+7vcOjz8MrTIlqZR0GK0J6AP+gvYzA6VC4JhfXCu xtEnwXhv3dcQMs+jJkSBx1PtmRJq7pMjhPWPNOKzGzLNdxMkHuJxsOmTm26qBgft++Dn 3FOxPmbvv7oKQTqgv2jfa5xaUo0Z60VPxJwqxlxr/mMxO/ANvtbVtS5m2bZGVVfXQ/Gb 0xAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716575034; x=1717179834; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iI5LPX8LqaFaVw1d3o/h8cFH5sAtkGM2Qf4ljWkA8MA=; b=nGP2qbXsCGd74VkP5ByIk3Wwar/Ghbjcs7gZ5YduWJDPlimhXIynJpUeOZq8RzNXrc MtMBpGe6fxl2mTcCCEG/uz6nuLMJ11a9J5ioCIiqJLYSBJGormzBx/WfmMYbRgSypzUH xeF3Rs1/bWIkGCwU72LuFLAR0jUfnwFqBa8KSKcW+JNen6ynkdMN6JDdh8EAD4p7+Jqm 5uutzD2bsknYcxE8HebDGNVwCqHWwZRru+CEFgj0f+iy2e1H1RTMrYPjt0qwMw/LYLmY Hr2fspm9Qe/Zy/yF9p8sw/DJkAJyCWlX7RtMh7JqD5eFD06BwvpMRLkt66BLrIDPz2GA YlGA== X-Forwarded-Encrypted: i=1; AJvYcCX/UHOJXtM+mYVy4K5eFyf0SYLV/sL9ACGfy/muqHZLlIqs79LAOfrCoJ5Drnzcpia3NXuqvf6G0WEQ+kdcJbjz2pBwe9fd6/I47ZUC+PGuB3/O1lBRm2+vz5F4xYVxwMW2wXAhays+zw== X-Gm-Message-State: AOJu0YzRG9Vl+8LNA2pvgWJ1RYCNsBcMFoJcJHGgD8BplHe5uzgNvDX8 gQkUc0RG1YIDKgTkTNHpRSQ98sVdvyX48MAYyoE5k8oG9ly1/3NE X-Google-Smtp-Source: AGHT+IH//vXEXAhD3qyq1mbG3Je7Zm2Y0dCg4naEt61T/ZQzNbWK9jkI1Mcj32VrYkt82OjplHe7Ng== X-Received: by 2002:aa7:8218:0:b0:6ed:21d5:fbdb with SMTP id d2e1a72fcca58-6f7726f5c79mr7083282b3a.8.1716575034173; Fri, 24 May 2024 11:23:54 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fbf2cfd1sm1388575b3a.3.2024.05.24.11.23.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 11:23:53 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 24 May 2024 11:23:51 -0700 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Alex Deucher Cc: Samuel Holland , Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/24/24 06:18, Alex Deucher wrote: > On Fri, May 24, 2024 at 9:17 AM Alex Deucher wrote: >> >> On Fri, May 24, 2024 at 5:16 AM Guenter Roeck wrote: >>> >>> Hi, >>> >>> On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: >>>> Now that all previously-supported architectures select >>>> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >>>> of the existing list of architectures. It can also take advantage of the >>>> common kernel-mode FPU API and method of adjusting CFLAGS. >>>> >>>> Acked-by: Alex Deucher >>>> Reviewed-by: Christoph Hellwig >>>> Signed-off-by: Samuel Holland >>> >>> With this patch in the mainline kernel, I get the following build error >>> when trying to build powerpc:ppc32_allmodconfig. >>> >>> powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o uses hard float, drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.o uses soft float >>> powerpc64-linux-ld: failed to merge target specific data of file drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o >>> >>> [ repeated many times ] >>> >>> The problem is no longer seen after reverting this patch. >> >> Should be fixed with this patch: >> https://gitlab.freedesktop.org/agd5f/linux/-/commit/5f56be33f33dd1d50b9433f842c879a20dc00f5b >> Will pull it into my -fixes branch. >> > > Nevermind, this is something else. > mdgpu_dm_helpers.o is built with -msoft-float, display_mode_lib.o is built with -mhard-float. -msoft-float is from arch/powerpc/Makefile:KBUILD_CFLAGS += $(CC_FLAGS_NO_FPU) -mhard-float is from drivers/gpu/drm/amd/display/dc/dml/Makefile:dml_ccflags := $(CC_FLAGS_FPU) drivers/gpu/drm/amd/display/dc/dml/Makefile:dml_rcflags := $(CC_FLAGS_NO_FPU) drivers/gpu/drm/amd/display/dc/dml2/Makefile:dml2_ccflags := $(CC_FLAGS_FPU) drivers/gpu/drm/amd/display/dc/dml2/Makefile:dml2_rcflags := $(CC_FLAGS_NO_FPU) Unfortunately I have no idea know how to resolve this. Guenter