From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
boqun.feng@gmail.com, paulmck@linux.ibm.com,
peterz@infradead.org, linux-arch@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs
Date: Tue, 16 Jul 2019 11:44:12 -0400 [thread overview]
Message-ID: <c1bbbe94-dbdc-da14-e0c3-850c965d8b5d@oracle.com> (raw)
In-Reply-To: <20190716150142.rebjmpjjiesaiwyt@gondor.apana.org.au>
On 7/16/19 11:01 AM, Herbert Xu wrote:
> On Tue, Jul 16, 2019 at 02:53:09PM +0200, Andrea Parri wrote:
>>
>> P1(atomic_t *reorder_objects, spinlock_t *pd_lock, spinlock_t *reorder_lock)
>> {
>> int r1;
>>
>> spin_lock(reorder_lock);
>> atomic_inc(reorder_objects);
>> spin_unlock(reorder_lock);
>> //smp_mb();
>> r1 = spin_trylock(pd_lock);
>> }
>
> Yes we need a matching mb on the other side. However, we can
> get away with using smp_mb__after_atomic thanks to the atomic_inc
> above.
>
> Daniel, can you please respin the patch with the matching smp_mb?
Sure, Herbert, will do.
Thanks,
Daniel
next prev parent reply other threads:[~2019-07-16 15:44 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:12 [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Daniel Jordan
2019-07-11 22:12 ` Daniel Jordan
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:10 ` Steffen Klassert
2019-07-12 10:10 ` Steffen Klassert
2019-07-12 16:07 ` Daniel Jordan
2019-07-12 16:07 ` Daniel Jordan
2019-07-13 5:03 ` Herbert Xu
2019-07-13 5:03 ` Herbert Xu
2019-07-15 16:10 ` Daniel Jordan
2019-07-15 16:10 ` Daniel Jordan
2019-07-16 10:04 ` Herbert Xu
2019-07-16 10:04 ` Herbert Xu
2019-07-16 11:14 ` Steffen Klassert
2019-07-16 11:14 ` Steffen Klassert
2019-07-16 12:57 ` [PATCH] padata: Use RCU when fetching pd from do_serial Herbert Xu
2019-07-16 12:57 ` Herbert Xu
2019-07-16 13:09 ` Herbert Xu
2019-07-16 13:09 ` Herbert Xu
2019-07-16 13:23 ` [v2 PATCH] " Herbert Xu
2019-07-16 13:23 ` Herbert Xu
2019-07-17 8:36 ` Steffen Klassert
2019-07-17 8:36 ` Steffen Klassert
2019-07-17 8:50 ` Herbert Xu
2019-07-17 8:50 ` Herbert Xu
2019-07-17 8:28 ` [PATCH] " Steffen Klassert
2019-07-17 8:28 ` Steffen Klassert
2019-07-17 8:47 ` Herbert Xu
2019-07-17 8:47 ` Herbert Xu
2019-07-17 8:53 ` Steffen Klassert
2019-07-17 8:53 ` Steffen Klassert
2019-07-16 13:15 ` Peter Zijlstra
2019-07-16 13:15 ` Peter Zijlstra
2019-07-16 13:18 ` Herbert Xu
2019-07-16 13:18 ` Herbert Xu
2019-07-16 13:50 ` Peter Zijlstra
2019-07-16 13:50 ` Peter Zijlstra
2019-07-16 13:52 ` Herbert Xu
2019-07-16 13:52 ` Herbert Xu
2019-07-16 12:53 ` [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Andrea Parri
2019-07-16 12:53 ` Andrea Parri
2019-07-16 13:13 ` Peter Zijlstra
2019-07-16 13:13 ` Peter Zijlstra
2019-07-16 15:01 ` Herbert Xu
2019-07-16 15:01 ` Herbert Xu
2019-07-16 15:44 ` Daniel Jordan [this message]
2019-07-16 15:44 ` Daniel Jordan
2019-07-16 16:32 ` [PATCH v2] " Daniel Jordan
2019-07-16 16:32 ` Daniel Jordan
2019-07-17 11:11 ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Herbert Xu
2019-07-17 11:11 ` Herbert Xu
2019-07-17 18:32 ` Daniel Jordan
2019-07-17 18:32 ` Daniel Jordan
2019-07-18 3:31 ` Herbert Xu
2019-07-18 3:31 ` Herbert Xu
2019-07-18 14:27 ` Daniel Jordan
2019-07-18 14:27 ` Daniel Jordan
2019-07-18 14:56 ` Herbert Xu
2019-07-18 14:56 ` Herbert Xu
2019-07-18 15:01 ` [v2 PATCH] " Herbert Xu
2019-07-18 15:01 ` Herbert Xu
2019-07-19 14:37 ` Daniel Jordan
2019-07-19 14:37 ` Daniel Jordan
2019-07-19 14:55 ` Herbert Xu
2019-07-19 14:55 ` Herbert Xu
2019-07-19 14:27 ` [PATCH] " Daniel Jordan
2019-07-19 14:27 ` Daniel Jordan
2019-07-17 23:21 ` Daniel Jordan
2019-07-17 23:21 ` Daniel Jordan
2019-07-18 3:30 ` Herbert Xu
2019-07-18 3:30 ` Herbert Xu
2019-07-18 14:25 ` Daniel Jordan
2019-07-18 14:25 ` Daniel Jordan
2019-07-18 14:49 ` Herbert Xu
2019-07-18 14:49 ` Herbert Xu
2019-07-19 14:21 ` Daniel Jordan
2019-07-19 14:21 ` Daniel Jordan
2019-07-18 5:42 ` [PATCH v2] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Herbert Xu
2019-07-18 5:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1bbbe94-dbdc-da14-e0c3-850c965d8b5d@oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox