From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A671FC433EF for ; Wed, 13 Oct 2021 11:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88F9B61056 for ; Wed, 13 Oct 2021 11:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbhJMLWk (ORCPT ); Wed, 13 Oct 2021 07:22:40 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:33735 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbhJMLWk (ORCPT ); Wed, 13 Oct 2021 07:22:40 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HTqpC28Spz9sSP; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZcpVFyhFd8g; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HTqpC0fNwz9sSN; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EE53D8B77E; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 3nizRho4O5jm; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [172.25.230.103]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B49778B763; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) Subject: Re: [PATCH v1 06/10] asm-generic: Refactor dereference_[kernel]_function_descriptor() To: Kees Cook , Helge Deller Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <202110130002.A7C0A86@keescook> From: Christophe Leroy Message-ID: Date: Wed, 13 Oct 2021 13:20:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202110130002.A7C0A86@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Le 13/10/2021 à 09:02, Kees Cook a écrit : > On Mon, Oct 11, 2021 at 05:25:33PM +0200, Christophe Leroy wrote: >> dereference_function_descriptor() and >> dereference_kernel_function_descriptor() are identical on the >> three architectures implementing them. >> >> Make it common. >> >> Signed-off-by: Christophe Leroy >> --- >> arch/ia64/include/asm/sections.h | 19 ------------------- >> arch/parisc/include/asm/sections.h | 9 --------- >> arch/parisc/kernel/process.c | 21 --------------------- >> arch/powerpc/include/asm/sections.h | 23 ----------------------- >> include/asm-generic/sections.h | 18 ++++++++++++++++++ >> 5 files changed, 18 insertions(+), 72 deletions(-) > > A diffstat to love. :) > > Reviewed-by: Kees Cook Unless somebody minds, I will make them out of line as suggested by Helge in he's comment to patch 4. Allthough there is no spectacular size reduction, the functions are not worth being inlined as they are not used in critical pathes.