From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia He Subject: Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again Date: Thu, 8 Feb 2018 10:37:54 +0800 Message-ID: References: <1517976694-2004-1-git-send-email-hejianet@gmail.com> <20180207114104.GA22549@e107981-ln.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180207114104.GA22549@e107981-ln.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Lorenzo Pieralisi Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Daniel Lezcano List-Id: linux-arch.vger.kernel.org On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote: > On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote: >> In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries >> probing"), iort entries was removed in vmlinux.lds.h. But in >> commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), >> this line was back incorrectly. >> >> It does no harm except for adding some useless symbols, so fix it. >> >> Signed-off-by: Jia He forget to add another Signed-off-by line(because of my company's opensource rules) Signed-off-by: Jia He >> --- >> include/asm-generic/vmlinux.lds.h | 1 - >> 1 file changed, 1 deletion(-) > Acked-by: Lorenzo Pieralisi > > Who is picking this up ? Sorry, do you mean who is picking up acpi/iort subsystem? I can't answer this question. I find this minor bug while doing the code review. Cheers, Jia >> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >> index 1ab0e52..58b1dab 100644 >> --- a/include/asm-generic/vmlinux.lds.h >> +++ b/include/asm-generic/vmlinux.lds.h >> @@ -589,7 +589,6 @@ >> IRQCHIP_OF_MATCH_TABLE() \ >> ACPI_PROBE_TABLE(irqchip) \ >> ACPI_PROBE_TABLE(timer) \ >> - ACPI_PROBE_TABLE(iort) \ >> EARLYCON_TABLE() >> >> #define INIT_TEXT \ >> -- >> 2.7.4 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:46431 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbeBHChv (ORCPT ); Wed, 7 Feb 2018 21:37:51 -0500 Subject: Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again References: <1517976694-2004-1-git-send-email-hejianet@gmail.com> <20180207114104.GA22549@e107981-ln.cambridge.arm.com> From: Jia He Message-ID: Date: Thu, 8 Feb 2018 10:37:54 +0800 MIME-Version: 1.0 In-Reply-To: <20180207114104.GA22549@e107981-ln.cambridge.arm.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Lorenzo Pieralisi Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Daniel Lezcano Message-ID: <20180208023754.HFiVy6xm0nrOKfSs3QQNPtXpPLpTrxOMxclji4rR4B4@z> On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote: > On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote: >> In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries >> probing"), iort entries was removed in vmlinux.lds.h. But in >> commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), >> this line was back incorrectly. >> >> It does no harm except for adding some useless symbols, so fix it. >> >> Signed-off-by: Jia He forget to add another Signed-off-by line(because of my company's opensource rules) Signed-off-by: Jia He >> --- >> include/asm-generic/vmlinux.lds.h | 1 - >> 1 file changed, 1 deletion(-) > Acked-by: Lorenzo Pieralisi > > Who is picking this up ? Sorry, do you mean who is picking up acpi/iort subsystem? I can't answer this question. I find this minor bug while doing the code review. Cheers, Jia >> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >> index 1ab0e52..58b1dab 100644 >> --- a/include/asm-generic/vmlinux.lds.h >> +++ b/include/asm-generic/vmlinux.lds.h >> @@ -589,7 +589,6 @@ >> IRQCHIP_OF_MATCH_TABLE() \ >> ACPI_PROBE_TABLE(irqchip) \ >> ACPI_PROBE_TABLE(timer) \ >> - ACPI_PROBE_TABLE(iort) \ >> EARLYCON_TABLE() >> >> #define INIT_TEXT \ >> -- >> 2.7.4 >>