From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B354C12F for ; Mon, 13 Nov 2023 04:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DwKRNRZa" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0429E111 for ; Sun, 12 Nov 2023 20:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699848246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MtNFooCff3vqCOUxCEz1jHRl+QbfPpBEZibpqDAaoCg=; b=DwKRNRZa+xVhO5aifoyoc0a6t/eISpLe5wUxbtFP4LcrQqkzayJZKHmdeTdL06ylZVhTgB K57bezKSZiCH92HkQd0Gr7QunNEs2Km3Mm1hsoDZtCQm1iuCezkPgP5NwqTxOVa4TUw/wV Nsgkfcwkgv5XgudM9ViwrFs7N0jgDes= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-70RiiA3cNxygzWicz9lGBA-1; Sun, 12 Nov 2023 23:04:04 -0500 X-MC-Unique: 70RiiA3cNxygzWicz9lGBA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1cc482cc026so54406915ad.2 for ; Sun, 12 Nov 2023 20:04:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699848243; x=1700453043; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MtNFooCff3vqCOUxCEz1jHRl+QbfPpBEZibpqDAaoCg=; b=TedCWuK7i2Hf68Es7J6n/rK1tBC4HVEp6iiWc5VQuWioHFMzQKZ+/YqIBVz7P1lpzX n5mdrO07/kMG4x4qbStuy6cY385GZAQ9ruW1GXLgxyg7dHG+oeNHH8fU80b5fjdi0akA mSjOmMbuoSlkZ+k7u24Q1b1LXTB904tdnVAz8e/4iNLXmMSjafZAmkr1P1FIe8NRHUxn FHkw+CtBE7Qxnk0jEkGls4CNhj0IO7YF5cAuHu1TwVovnIoZArzSIM1ktSpP2E7hwRT1 +FBIWsj5BW4q35KjVGXXbeGDDOgdecfMK17O2crSbQewUu7WlZeRiCvw1S+sirtmfQSz fYww== X-Gm-Message-State: AOJu0YyVbZudrm6fGMpOHJFNHzbWB0vwAupNHlT2casYydN2FTMWaato dQ/whRI8+nX0Xa7J0g/7CqzK69JJ1M9+k8Yb6OhCXsqF8B+k1r5QWyNkqhFKAHmIuuHzDVz06rZ TZnyKN8WZfsoVBvTKDGpaqA== X-Received: by 2002:a17:903:124b:b0:1cc:3f10:4175 with SMTP id u11-20020a170903124b00b001cc3f104175mr7395305plh.28.1699848243618; Sun, 12 Nov 2023 20:04:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIUBgi1/lc4Y3idUGi3EHadW6QYxPGSgwR1L+ZBVEJt2K4HesJHzLX8fXA3t0WRPADwpmGUg== X-Received: by 2002:a17:903:124b:b0:1cc:3f10:4175 with SMTP id u11-20020a170903124b00b001cc3f104175mr7395280plh.28.1699848243280; Sun, 12 Nov 2023 20:04:03 -0800 (PST) Received: from ?IPV6:2001:8003:e5b0:9f00:b890:3e54:96bb:2a15? ([2001:8003:e5b0:9f00:b890:3e54:96bb:2a15]) by smtp.gmail.com with ESMTPSA id u18-20020a170902e5d200b001c62d63b817sm3216342plf.179.2023.11.12.20.03.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 20:04:02 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:03:53 +1000 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails Content-Language: en-US To: "Russell King (Oracle)" , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" , Paul Walmsley , Palmer Dabbelt , Albert Ou References: From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/7/23 20:30, Russell King (Oracle) wrote: > From: James Morse > > loongarch, mips, parisc, riscv and sh all print a warning if > register_cpu() returns an error. Architectures that use > GENERIC_CPU_DEVICES call panic() instead. > > Errors in this path indicate something is wrong with the firmware > description of the platform, but the kernel is able to keep running. > > Downgrade this to a warning to make it easier to debug this issue. > > This will allow architectures that switching over to GENERIC_CPU_DEVICES > to drop their warning, but keep the existing behaviour. > > Signed-off-by: James Morse > Reviewed-by: Russell King (Oracle) > Signed-off-by: Russell King (Oracle) > --- > drivers/base/cpu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Gavin Shan