From: "Arnd Bergmann" <arnd@arndb.de>
To: "Baoquan He" <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
linux-mm@kvack.org, "Andrew Morton" <akpm@linux-foundation.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Helge Deller" <deller@gmx.de>,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures
Date: Thu, 21 Sep 2023 08:27:14 -0400 [thread overview]
Message-ID: <c4a96578-b27c-44fa-82ef-1c5bf43b972a@app.fastmail.com> (raw)
In-Reply-To: <20230921110424.215592-4-bhe@redhat.com>
On Thu, Sep 21, 2023, at 07:04, Baoquan He wrote:
> ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> extension, and on ia64 with its slightly unconventional ioremap()
> behavior. So remove the ioremap_uc() definition in architecutures
> other than x86 and ia64. These architectures all have asm-generic/io.h
> included and will have the default ioremap_uc() definition which
> returns NULL.
>
> This changes the existing behaviour, while no need to worry about
> any breakage because in the only callsite of ioremap_uc(), code
> has been adjusted to eliminate the impact. Please see
> atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c.
>
> If any new invocation of ioremap_uc() need be added, please consider
> using ioremap() intead or adding a ARCH specific version if necessary.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Acked-by: Helge Deller <deller@gmx.de> # parisc
> Cc: linux-alpha@vger.kernel.org
> Cc: linux-hexagon@vger.kernel.org
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: linux-mips@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-sh@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-09-21 21:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 11:04 [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-09-21 11:04 ` [PATCH v5 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Baoquan He
2023-09-23 18:53 ` Helge Deller
2023-09-21 11:04 ` [PATCH v5 2/4] mips: add <asm-generic/io.h> including Baoquan He
2023-10-06 8:05 ` Thomas Bogendoerfer
2023-09-21 11:04 ` [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-09-21 12:27 ` Arnd Bergmann [this message]
2023-10-06 8:05 ` Thomas Bogendoerfer
2023-10-06 8:31 ` John Paul Adrian Glaubitz
2023-09-21 11:04 ` [PATCH v5 4/4] mips: io: remove duplicated codes Baoquan He
2023-09-21 12:24 ` Arnd Bergmann
2023-10-06 8:06 ` Thomas Bogendoerfer
2023-10-26 12:36 ` [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures Jiaxun Yang
2023-10-26 23:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4a96578-b27c-44fa-82ef-1c5bf43b972a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=deller@gmx.de \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).