From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Date: Mon, 18 Dec 2017 20:12:41 +0100 Message-ID: References: <20171213092550.2774-1-mhocko@kernel.org> <20171213093110.3550-1-mhocko@kernel.org> <20171213093110.3550-2-mhocko@kernel.org> <20171213125540.GA18897@amd> <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: owner-linux-mm@kvack.org To: Kees Cook , Cyril Hrubis Cc: mtk.manpages@gmail.com, Pavel Machek , Michal Hocko , Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport List-Id: linux-arch.vger.kernel.org Hello Kees, I'm late to the party, and only just caught up with the fuss :-). On 12/14/2017 12:19 AM, Kees Cook wrote: > On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: >> Hi! >>> You selected stupid name for a flag. Everyone and their dog agrees >>> with that. There's even consensus on better name (and everyone agrees >>> it is better than .._SAFE). Of course, we could have debate if it is >>> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >>> poor naming on your part. >> >> Well while everybody agrees that the name is so bad that basically >> anything else would be better, there does not seem to be consensus on >> which one to pick. I do understand that this frustrating and fruitless. > > Based on the earlier threads where I tried to end the bikeshedding, it > seemed like MAP_FIXED_NOREPLACE was the least bad option. > >> So what do we do now, roll a dice to choose new name? >> >> Or do we ask BFDL[1] to choose the name? > > I'd like to hear feedback from Michael Kerrisk, as he's had to deal > with these kinds of choices in the past. I'm fine to ask Linus too. I > just want to get past the name since the feature is quite valuable. > > And if Michal doesn't want to touch this patch any more, I'm happy to > do the search/replace/resend. :P Something with the prefix MAP_FIXED_ seems to me obviously desirable, both to suggest that the function is similar, and also for easy grepping of the source code to look for instances of both. MAP_FIXED_SAFE didn't really bother me as a name, but MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more descriptive of what the flag actually does, so a little better. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:45927 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934636AbdLRTMt (ORCPT ); Mon, 18 Dec 2017 14:12:49 -0500 Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation References: <20171213092550.2774-1-mhocko@kernel.org> <20171213093110.3550-1-mhocko@kernel.org> <20171213093110.3550-2-mhocko@kernel.org> <20171213125540.GA18897@amd> <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Mon, 18 Dec 2017 20:12:41 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook , Cyril Hrubis Cc: mtk.manpages@gmail.com, Pavel Machek , Michal Hocko , Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport Message-ID: <20171218191241.UrplnRPePyVHvsMQrkmykl1069lY2TrhZDTK224FDy8@z> Hello Kees, I'm late to the party, and only just caught up with the fuss :-). On 12/14/2017 12:19 AM, Kees Cook wrote: > On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: >> Hi! >>> You selected stupid name for a flag. Everyone and their dog agrees >>> with that. There's even consensus on better name (and everyone agrees >>> it is better than .._SAFE). Of course, we could have debate if it is >>> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >>> poor naming on your part. >> >> Well while everybody agrees that the name is so bad that basically >> anything else would be better, there does not seem to be consensus on >> which one to pick. I do understand that this frustrating and fruitless. > > Based on the earlier threads where I tried to end the bikeshedding, it > seemed like MAP_FIXED_NOREPLACE was the least bad option. > >> So what do we do now, roll a dice to choose new name? >> >> Or do we ask BFDL[1] to choose the name? > > I'd like to hear feedback from Michael Kerrisk, as he's had to deal > with these kinds of choices in the past. I'm fine to ask Linus too. I > just want to get past the name since the feature is quite valuable. > > And if Michal doesn't want to touch this patch any more, I'm happy to > do the search/replace/resend. :P Something with the prefix MAP_FIXED_ seems to me obviously desirable, both to suggest that the function is similar, and also for easy grepping of the source code to look for instances of both. MAP_FIXED_SAFE didn't really bother me as a name, but MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more descriptive of what the flag actually does, so a little better. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/