From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Cc: Andy Lutomirski <luto@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>, Theodore Ts'o <tytso@mit.edu>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
Date: Thu, 10 Oct 2024 13:35:24 +0100 [thread overview]
Message-ID: <c9360dce-559c-4523-b98c-041fc748ce61@arm.com> (raw)
In-Reply-To: <87wmihr49g.ffs@tglx>
On 09/10/2024 10:53, Thomas Gleixner wrote:
> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:
>> The VDSO implementation includes headers from outside of the
>> vdso/ namespace.
>>
>> Introduce vdso/page.h to make sure that the generic library
>> uses only the allowed namespace.
>>
>> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when
>> it supports 64-bit phys_addr_t we might end up in situation in which
>> the
>
> We end up with nothing.
>
>> top 32 bit are cleared. To prevent this issue this patch provides
>> separate macros for PAGE_MASK.
>
> 'this patch' is redundant information.
>
> git grep 'This patch' Documentation/process/
>
My bad, I thought that Documentation/process/submitting-patches.rst referred
only to the proposed change which is in imperative mood.
I will rephrase it accordingly.
...
>> +#define PAGE_MASK (~(PAGE_SIZE-1))
>
> #define PAGE_MASK (~(PAGE_SIZE - 1))
>
> please.
>
Will change it in v4.
> Thanks,
>
> tglx
--
Regards,
Vincenzo
next prev parent reply other threads:[~2024-10-10 12:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 15:29 [PATCH v3 0/2] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-10-03 15:29 ` [PATCH v3 1/2] drm: Fix fault format Vincenzo Frascino
2024-10-04 13:21 ` Arnd Bergmann
2024-10-07 6:10 ` Christophe Leroy
2024-10-03 15:29 ` [PATCH v3 2/2] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-10-04 9:07 ` Geert Uytterhoeven
2024-10-04 13:13 ` Arnd Bergmann
2024-10-07 11:01 ` Vincenzo Frascino
2024-10-07 11:06 ` Arnd Bergmann
2024-10-07 11:20 ` Vincenzo Frascino
2024-10-07 16:05 ` H. Peter Anvin
2024-10-07 16:23 ` Thomas Gleixner
2024-10-08 13:11 ` Arnd Bergmann
2024-10-08 14:20 ` Vincenzo Frascino
2024-10-09 9:53 ` Thomas Gleixner
2024-10-09 10:04 ` Thomas Gleixner
2024-10-09 23:58 ` Michael Ellerman
2024-10-10 12:37 ` Vincenzo Frascino
2024-10-10 12:36 ` Vincenzo Frascino
2024-10-10 12:35 ` Vincenzo Frascino [this message]
2024-10-03 16:25 ` [PATCH v3 0/2] vdso: Use only headers from the vdso/ namespace Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9360dce-559c-4523-b98c-041fc748ce61@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).