From: Roman Kisel <romank@linux.microsoft.com>
To: Marc Zyngier <maz@kernel.org>
Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de,
catalin.marinas@arm.com, conor+dt@kernel.org,
dan.carpenter@linaro.org, dave.hansen@linux.intel.com,
decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com,
joey.gouly@arm.com, krzk+dt@kernel.org, kw@linux.com,
kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org,
manivannan.sadhasivam@linaro.org, mark.rutland@arm.com,
mingo@redhat.com, oliver.upton@linux.dev, rafael@kernel.org,
robh@kernel.org, rafael.j.wysocki@intel.com,
ssengar@linux.microsoft.com, sudeep.holla@arm.com,
suzuki.poulose@arm.com, tglx@linutronix.de, wei.liu@kernel.org,
will@kernel.org, yuzenghui@huawei.com,
devicetree@vger.kernel.org, kvmarm@lists.linux.dev,
linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, x86@kernel.org, apais@microsoft.com,
benhill@microsoft.com, bperkins@microsoft.com,
sunilmut@microsoft.com
Subject: Re: [PATCH hyperv-next v7 01/11] arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID
Date: Tue, 8 Apr 2025 09:16:16 -0700 [thread overview]
Message-ID: <c9bea07c-3a0e-41bb-a8d8-12d9f8776e07@linux.microsoft.com> (raw)
In-Reply-To: <86semjku7x.wl-maz@kernel.org>
On 4/8/2025 12:06 AM, Marc Zyngier wrote:
> On Mon, 07 Apr 2025 21:13:26 +0100,
> Roman Kisel <romank@linux.microsoft.com> wrote:
[...]
>>
>> #include <linux/args.h>
>> #include <linux/init.h>
>> +
>> +#ifndef __ASSEMBLER__
>> +#include <linux/uuid.h>
>> +#endif
>
> That's a pretty unusual guard in arm64 land. Looking at the current
> state of the kernel:
>
> $ git grep -w __ASSEMBLER__ arch/arm64/ | wc -l
> 2
> $ git grep -w __ASSEMBLY__ arch/arm64/ | wc -l
> 122
>
> I'd suggest the later rather than the former.
Thanks for catching this! I'll be sure to change this to use the arm64
coding conventions in the next version.
>
> Thanks,
>
> M.
>
--
Thank you,
Roman
next prev parent reply other threads:[~2025-04-08 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 20:13 [PATCH hyperv-next v7 00/11] arm64: hyperv: Support Virtual Trust Level Boot Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 01/11] arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID Roman Kisel
2025-04-08 7:06 ` Marc Zyngier
2025-04-08 16:16 ` Roman Kisel [this message]
2025-04-07 20:13 ` [PATCH hyperv-next v7 02/11] arm64: hyperv: Use SMCCC to detect hypervisor presence Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 03/11] Drivers: hv: Enable VTL mode for arm64 Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 04/11] Drivers: hv: Provide arch-neutral implementation of get_vtl() Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 05/11] arm64: hyperv: Initialize the Virtual Trust Level field Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 06/11] arm64, x86: hyperv: Report the VTL the system boots in Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 07/11] dt-bindings: microsoft,vmbus: Add interrupt and DMA coherence properties Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 09/11] Drivers: hv: vmbus: Introduce hv_get_vmbus_root_device() Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 10/11] ACPI: irq: Introduce acpi_get_gsi_dispatcher() Roman Kisel
2025-04-07 20:13 ` [PATCH hyperv-next v7 11/11] PCI: hv: Get vPCI MSI IRQ domain from DeviceTree Roman Kisel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9bea07c-3a0e-41bb-a8d8-12d9f8776e07@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=arnd@arndb.de \
--cc=benhill@microsoft.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bperkins@microsoft.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=joey.gouly@arm.com \
--cc=krzk+dt@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=sudeep.holla@arm.com \
--cc=sunilmut@microsoft.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).