From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v2 20/20] arm64: vdso32: Enable Clang Compilation Date: Fri, 13 Mar 2020 12:01:57 +0000 Message-ID: References: <20200306133242.26279-1-vincenzo.frascino@arm.com> <20200306133242.26279-21-vincenzo.frascino@arm.com> <20200310014039.GA12211@ubuntu-m2-xlarge-x86> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.110.172]:53730 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbgCMMBg (ORCPT ); Fri, 13 Mar 2020 08:01:36 -0400 In-Reply-To: <20200310014039.GA12211@ubuntu-m2-xlarge-x86> Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nathan Chancellor Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers On 3/10/20 1:40 AM, Nathan Chancellor wrote: > On Fri, Mar 06, 2020 at 01:32:42PM +0000, Vincenzo Frascino wrote: >> Enable Clang Compilation for the vdso32 library. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Signed-off-by: Vincenzo Frascino >> --- >> arch/arm64/kernel/vdso32/Makefile | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile >> index 04df57b43cb1..650cfc5757eb 100644 >> --- a/arch/arm64/kernel/vdso32/Makefile >> +++ b/arch/arm64/kernel/vdso32/Makefile >> @@ -10,7 +10,18 @@ include $(srctree)/lib/vdso/Makefile >> >> # Same as cc-*option, but using CC_COMPAT instead of CC >> ifeq ($(CONFIG_CC_IS_CLANG), y) >> -CC_COMPAT ?= $(CC) >> +COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) >> +COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) >> + >> +CLANG_CC_COMPAT := $(CC) >> +CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) >> +CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) >> +CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments >> +ifneq ($(COMPAT_GCC_TOOLCHAIN),) >> +CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) >> +endif >> + >> +CC_COMPAT ?= $(CLANG_CC_COMPAT) >> else >> CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc >> endif >> -- >> 2.25.1 >> > If CC_COMPAT is ever specified on the command line as clang (maybe by > some unsuspecting user), we'd loose all of the above flags. Maybe it > would be better to build a set of COMPAT_CLANG_FLAGS and append them to > CC_COMPAT, maybe like below? > Fine by me. > Regardless, the current approach works in my testing with clang 9.0.1 > and master (clang 11.0.0). This patch specifically is: > Good to hear. I will add your tags to the patch. > Reviewed-by: Nathan Chancellor > Tested-by: Nathan Chancellor # build > > ================================================================================== > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 650cfc5757eb..df5145fab287 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -13,15 +13,16 @@ ifeq ($(CONFIG_CC_IS_CLANG), y) > COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) > COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) > > -CLANG_CC_COMPAT := $(CC) > -CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > -CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > -CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments > +COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > +COMPAT_CLANG_FLAGS += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > +COMPAT_CLANG_FLAGS += -no-integrated-as -Qunused-arguments > ifneq ($(COMPAT_GCC_TOOLCHAIN),) > -CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > +COMPAT_CLANG_FLAGS += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > endif > > -CC_COMPAT ?= $(CLANG_CC_COMPAT) > +CC_COMPAT ?= $(CC) > +CC_COMPAT += $(COMPAT_CLANG_FLAGS) > + > else > CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > endif > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.110.172]:53730 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbgCMMBg (ORCPT ); Fri, 13 Mar 2020 08:01:36 -0400 Subject: Re: [PATCH v2 20/20] arm64: vdso32: Enable Clang Compilation References: <20200306133242.26279-1-vincenzo.frascino@arm.com> <20200306133242.26279-21-vincenzo.frascino@arm.com> <20200310014039.GA12211@ubuntu-m2-xlarge-x86> From: Vincenzo Frascino Message-ID: Date: Fri, 13 Mar 2020 12:01:57 +0000 MIME-Version: 1.0 In-Reply-To: <20200310014039.GA12211@ubuntu-m2-xlarge-x86> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nathan Chancellor Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers , Will Deacon Message-ID: <20200313120157.P56sAYrk4iqSlzufQZPZSexWaP-hKzggfjRFrl-YX2c@z> On 3/10/20 1:40 AM, Nathan Chancellor wrote: > On Fri, Mar 06, 2020 at 01:32:42PM +0000, Vincenzo Frascino wrote: >> Enable Clang Compilation for the vdso32 library. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Signed-off-by: Vincenzo Frascino >> --- >> arch/arm64/kernel/vdso32/Makefile | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile >> index 04df57b43cb1..650cfc5757eb 100644 >> --- a/arch/arm64/kernel/vdso32/Makefile >> +++ b/arch/arm64/kernel/vdso32/Makefile >> @@ -10,7 +10,18 @@ include $(srctree)/lib/vdso/Makefile >> >> # Same as cc-*option, but using CC_COMPAT instead of CC >> ifeq ($(CONFIG_CC_IS_CLANG), y) >> -CC_COMPAT ?= $(CC) >> +COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) >> +COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) >> + >> +CLANG_CC_COMPAT := $(CC) >> +CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) >> +CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) >> +CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments >> +ifneq ($(COMPAT_GCC_TOOLCHAIN),) >> +CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) >> +endif >> + >> +CC_COMPAT ?= $(CLANG_CC_COMPAT) >> else >> CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc >> endif >> -- >> 2.25.1 >> > If CC_COMPAT is ever specified on the command line as clang (maybe by > some unsuspecting user), we'd loose all of the above flags. Maybe it > would be better to build a set of COMPAT_CLANG_FLAGS and append them to > CC_COMPAT, maybe like below? > Fine by me. > Regardless, the current approach works in my testing with clang 9.0.1 > and master (clang 11.0.0). This patch specifically is: > Good to hear. I will add your tags to the patch. > Reviewed-by: Nathan Chancellor > Tested-by: Nathan Chancellor # build > > ================================================================================== > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 650cfc5757eb..df5145fab287 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -13,15 +13,16 @@ ifeq ($(CONFIG_CC_IS_CLANG), y) > COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) > COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) > > -CLANG_CC_COMPAT := $(CC) > -CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > -CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > -CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments > +COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > +COMPAT_CLANG_FLAGS += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > +COMPAT_CLANG_FLAGS += -no-integrated-as -Qunused-arguments > ifneq ($(COMPAT_GCC_TOOLCHAIN),) > -CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > +COMPAT_CLANG_FLAGS += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > endif > > -CC_COMPAT ?= $(CLANG_CC_COMPAT) > +CC_COMPAT ?= $(CC) > +CC_COMPAT += $(COMPAT_CLANG_FLAGS) > + > else > CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > endif > -- Regards, Vincenzo