* [PATCH v2 0/2] Enabling MSI for Microblaze
2019-10-25 6:10 [PATCH v2 0/2] Enabling MSI for Microblaze Michal Simek
@ 2019-10-25 6:10 ` Michal Simek
2019-10-25 6:10 ` [PATCH v2 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
2019-10-25 20:45 ` [PATCH v2 0/2] Enabling MSI for Microblaze Bjorn Helgaas
2 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2019-10-25 6:10 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman,
helgaas
Cc: Arnd Bergmann, Jackie Liu, Wesley Terpstra, Firoz Khan,
sparclinux, Ingo Molnar, Catalin Marinas, Ard Biesheuvel,
linux-riscv, linux-arch, James Hogan, Vineet Gupta, Bjorn Helgaas,
linux-pci, Greg Kroah-Hartman, Ralf Baechle, Paul Walmsley,
Peter Zijlstra (Intel), Will Deacon, Benjamin Herrenschmidt,
Greg Ungerer, Paul Burton, Herbert Xu, Russell King,
linux-arm-kernel, Albert Ou, linux-snps-arc, David S. Miller,
Eric Biggers, Michael Ellerman, linux-mips, Masahiro Yamada,
Paul Mackerras, linuxppc-dev
Hi,
these two patches come from discussion with Christoph, Bjorn, Palmer and
Waiman. The first patch was suggestion by Christoph here
https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
The second part was discussed
https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
and
https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/
Thanks,
Michal
Changes in v2:
- Fix typo in commit message s/expect/except/ - Reported-by: Masahiro
Michal Simek (1):
asm-generic: Make msi.h a mandatory include/asm header
Palmer Dabbelt (1):
pci: Default to PCI_MSI_IRQ_DOMAIN
arch/arc/include/asm/Kbuild | 1 -
arch/arm/include/asm/Kbuild | 1 -
arch/arm64/include/asm/Kbuild | 1 -
arch/mips/include/asm/Kbuild | 1 -
arch/powerpc/include/asm/Kbuild | 1 -
arch/riscv/include/asm/Kbuild | 1 -
arch/sparc/include/asm/Kbuild | 1 -
drivers/pci/Kconfig | 2 +-
include/asm-generic/Kbuild | 1 +
9 files changed, 2 insertions(+), 8 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] asm-generic: Make msi.h a mandatory include/asm header
2019-10-25 6:10 [PATCH v2 0/2] Enabling MSI for Microblaze Michal Simek
2019-10-25 6:10 ` Michal Simek
@ 2019-10-25 6:10 ` Michal Simek
2019-10-25 6:10 ` Michal Simek
2019-10-25 20:45 ` [PATCH v2 0/2] Enabling MSI for Microblaze Bjorn Helgaas
2 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2019-10-25 6:10 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman,
helgaas
Cc: Catalin Marinas, Eric Biggers, Peter Zijlstra (Intel),
Benjamin Herrenschmidt, Masahiro Yamada, Paul Mackerras,
sparclinux, linux-riscv, Will Deacon, Greg Ungerer, linux-arch,
Herbert Xu, Michael Ellerman, Jackie Liu, Russell King,
Ingo Molnar, Firoz Khan, Wesley Terpstra, James Hogan,
linux-snps-arc, Albert Ou, Arnd Bergmann, Paul Walmsley,
linux-arm-kernel
msi.h is generic for all architectures except of x86 which has own version.
Enabling MSI by including msi.h to architecture Kbuild is just additional
step which doesn't need to be done.
The patch was created based on request to enable MSI for Microblaze.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Paul Walmsley <paul.walmsley@sifive.com> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@sifive.com> # build only, rv32/rv64
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Fix typo in commit message s/expect/except/ - Reported-by: Masahiro
https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
---
arch/arc/include/asm/Kbuild | 1 -
arch/arm/include/asm/Kbuild | 1 -
arch/arm64/include/asm/Kbuild | 1 -
arch/mips/include/asm/Kbuild | 1 -
arch/powerpc/include/asm/Kbuild | 1 -
arch/riscv/include/asm/Kbuild | 1 -
arch/sparc/include/asm/Kbuild | 1 -
include/asm-generic/Kbuild | 1 +
8 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
index 393d4f5e1450..1b505694691e 100644
--- a/arch/arc/include/asm/Kbuild
+++ b/arch/arc/include/asm/Kbuild
@@ -17,7 +17,6 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += parport.h
generic-y += percpu.h
generic-y += preempt.h
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 68ca86f85eb7..fa579b23b4df 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -12,7 +12,6 @@ generic-y += local.h
generic-y += local64.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += parport.h
generic-y += preempt.h
generic-y += seccomp.h
diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
index 98a5405c8558..bd23f87d6c55 100644
--- a/arch/arm64/include/asm/Kbuild
+++ b/arch/arm64/include/asm/Kbuild
@@ -16,7 +16,6 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += qrwlock.h
generic-y += qspinlock.h
generic-y += serial.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index c8b595c60910..61b0fc2026e6 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -13,7 +13,6 @@ generic-y += irq_work.h
generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
-generic-y += msi.h
generic-y += parport.h
generic-y += percpu.h
generic-y += preempt.h
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 64870c7be4a3..17726f2e46de 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -10,4 +10,3 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += preempt.h
generic-y += vtime.h
-generic-y += msi.h
diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
index 16970f246860..1efaeddf1e4b 100644
--- a/arch/riscv/include/asm/Kbuild
+++ b/arch/riscv/include/asm/Kbuild
@@ -22,7 +22,6 @@ generic-y += kvm_para.h
generic-y += local.h
generic-y += local64.h
generic-y += mm-arch-hooks.h
-generic-y += msi.h
generic-y += percpu.h
generic-y += preempt.h
generic-y += sections.h
diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
index b6212164847b..62de2eb2773d 100644
--- a/arch/sparc/include/asm/Kbuild
+++ b/arch/sparc/include/asm/Kbuild
@@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
generic-y += module.h
-generic-y += msi.h
generic-y += preempt.h
generic-y += serial.h
generic-y += trace_clock.h
diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index adff14fcb8e4..ddfee1bd9dc1 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -4,4 +4,5 @@
# (This file is not included when SRCARCH=um since UML borrows several
# asm headers from the host architecutre.)
+mandatory-y += msi.h
mandatory-y += simd.h
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] asm-generic: Make msi.h a mandatory include/asm header
2019-10-25 6:10 ` [PATCH v2 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-25 6:10 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2019-10-25 6:10 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman,
helgaas
Cc: Arnd Bergmann, Jackie Liu, Wesley Terpstra, Firoz Khan,
sparclinux, Ingo Molnar, Catalin Marinas, Ard Biesheuvel,
linux-riscv, linux-arch, James Hogan, Vineet Gupta,
Greg Kroah-Hartman, Ralf Baechle, Paul Walmsley,
Peter Zijlstra (Intel), Will Deacon, Benjamin Herrenschmidt,
Greg Ungerer, Paul Burton, Herbert Xu, Russell King,
linux-arm-kernel, Albert Ou, linux-snps-arc, David S. Miller,
Eric Biggers, Michael Ellerman, linux-mips, Masahiro Yamada,
Paul Mackerras, linuxppc-dev
msi.h is generic for all architectures except of x86 which has own version.
Enabling MSI by including msi.h to architecture Kbuild is just additional
step which doesn't need to be done.
The patch was created based on request to enable MSI for Microblaze.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Paul Walmsley <paul.walmsley@sifive.com> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@sifive.com> # build only, rv32/rv64
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Fix typo in commit message s/expect/except/ - Reported-by: Masahiro
https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
---
arch/arc/include/asm/Kbuild | 1 -
arch/arm/include/asm/Kbuild | 1 -
arch/arm64/include/asm/Kbuild | 1 -
arch/mips/include/asm/Kbuild | 1 -
arch/powerpc/include/asm/Kbuild | 1 -
arch/riscv/include/asm/Kbuild | 1 -
arch/sparc/include/asm/Kbuild | 1 -
include/asm-generic/Kbuild | 1 +
8 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
index 393d4f5e1450..1b505694691e 100644
--- a/arch/arc/include/asm/Kbuild
+++ b/arch/arc/include/asm/Kbuild
@@ -17,7 +17,6 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += parport.h
generic-y += percpu.h
generic-y += preempt.h
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 68ca86f85eb7..fa579b23b4df 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -12,7 +12,6 @@ generic-y += local.h
generic-y += local64.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += parport.h
generic-y += preempt.h
generic-y += seccomp.h
diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
index 98a5405c8558..bd23f87d6c55 100644
--- a/arch/arm64/include/asm/Kbuild
+++ b/arch/arm64/include/asm/Kbuild
@@ -16,7 +16,6 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
-generic-y += msi.h
generic-y += qrwlock.h
generic-y += qspinlock.h
generic-y += serial.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index c8b595c60910..61b0fc2026e6 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -13,7 +13,6 @@ generic-y += irq_work.h
generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
-generic-y += msi.h
generic-y += parport.h
generic-y += percpu.h
generic-y += preempt.h
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 64870c7be4a3..17726f2e46de 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -10,4 +10,3 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += preempt.h
generic-y += vtime.h
-generic-y += msi.h
diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
index 16970f246860..1efaeddf1e4b 100644
--- a/arch/riscv/include/asm/Kbuild
+++ b/arch/riscv/include/asm/Kbuild
@@ -22,7 +22,6 @@ generic-y += kvm_para.h
generic-y += local.h
generic-y += local64.h
generic-y += mm-arch-hooks.h
-generic-y += msi.h
generic-y += percpu.h
generic-y += preempt.h
generic-y += sections.h
diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
index b6212164847b..62de2eb2773d 100644
--- a/arch/sparc/include/asm/Kbuild
+++ b/arch/sparc/include/asm/Kbuild
@@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
generic-y += module.h
-generic-y += msi.h
generic-y += preempt.h
generic-y += serial.h
generic-y += trace_clock.h
diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index adff14fcb8e4..ddfee1bd9dc1 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -4,4 +4,5 @@
# (This file is not included when SRCARCH=um since UML borrows several
# asm headers from the host architecutre.)
+mandatory-y += msi.h
mandatory-y += simd.h
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Enabling MSI for Microblaze
2019-10-25 6:10 [PATCH v2 0/2] Enabling MSI for Microblaze Michal Simek
2019-10-25 6:10 ` Michal Simek
2019-10-25 6:10 ` [PATCH v2 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-25 20:45 ` Bjorn Helgaas
2019-10-25 20:45 ` Bjorn Helgaas
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2019-10-25 20:45 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, palmer, hch, longman, Arnd Bergmann,
Jackie Liu, Wesley Terpstra, Firoz Khan, sparclinux, Ingo Molnar,
Catalin Marinas, Ard Biesheuvel, linux-riscv, linux-arch,
James Hogan, Vineet Gupta, linux-pci, Greg Kroah-Hartman,
Ralf Baechle, Paul Walmsley, Peter Zijlstra (Intel), Will Deacon
On Fri, Oct 25, 2019 at 08:10:36AM +0200, Michal Simek wrote:
> Hi,
>
> these two patches come from discussion with Christoph, Bjorn, Palmer and
> Waiman. The first patch was suggestion by Christoph here
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> The second part was discussed
> https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
> and
> https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/
>
> Thanks,
> Michal
>
> Changes in v2:
> - Fix typo in commit message s/expect/except/ - Reported-by: Masahiro
>
> Michal Simek (1):
> asm-generic: Make msi.h a mandatory include/asm header
>
> Palmer Dabbelt (1):
> pci: Default to PCI_MSI_IRQ_DOMAIN
>
> arch/arc/include/asm/Kbuild | 1 -
> arch/arm/include/asm/Kbuild | 1 -
> arch/arm64/include/asm/Kbuild | 1 -
> arch/mips/include/asm/Kbuild | 1 -
> arch/powerpc/include/asm/Kbuild | 1 -
> arch/riscv/include/asm/Kbuild | 1 -
> arch/sparc/include/asm/Kbuild | 1 -
> drivers/pci/Kconfig | 2 +-
> include/asm-generic/Kbuild | 1 +
> 9 files changed, 2 insertions(+), 8 deletions(-)
I applied these to pci/msi for v5.5, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Enabling MSI for Microblaze
2019-10-25 20:45 ` [PATCH v2 0/2] Enabling MSI for Microblaze Bjorn Helgaas
@ 2019-10-25 20:45 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2019-10-25 20:45 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, palmer, hch, longman, Arnd Bergmann,
Jackie Liu, Wesley Terpstra, Firoz Khan, sparclinux, Ingo Molnar,
Catalin Marinas, Ard Biesheuvel, linux-riscv, linux-arch,
James Hogan, Vineet Gupta, linux-pci, Greg Kroah-Hartman,
Ralf Baechle, Paul Walmsley, Peter Zijlstra (Intel), Will Deacon,
Benjamin Herrenschmidt, Greg Ungerer, Paul Burton, Herbert Xu,
Russell King, linux-arm-kernel, Albert Ou, linux-snps-arc,
David S. Miller, Eric Biggers, Michael Ellerman, linux-mips,
Masahiro Yamada, Paul Mackerras, linuxppc-dev
On Fri, Oct 25, 2019 at 08:10:36AM +0200, Michal Simek wrote:
> Hi,
>
> these two patches come from discussion with Christoph, Bjorn, Palmer and
> Waiman. The first patch was suggestion by Christoph here
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> The second part was discussed
> https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
> and
> https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/
>
> Thanks,
> Michal
>
> Changes in v2:
> - Fix typo in commit message s/expect/except/ - Reported-by: Masahiro
>
> Michal Simek (1):
> asm-generic: Make msi.h a mandatory include/asm header
>
> Palmer Dabbelt (1):
> pci: Default to PCI_MSI_IRQ_DOMAIN
>
> arch/arc/include/asm/Kbuild | 1 -
> arch/arm/include/asm/Kbuild | 1 -
> arch/arm64/include/asm/Kbuild | 1 -
> arch/mips/include/asm/Kbuild | 1 -
> arch/powerpc/include/asm/Kbuild | 1 -
> arch/riscv/include/asm/Kbuild | 1 -
> arch/sparc/include/asm/Kbuild | 1 -
> drivers/pci/Kconfig | 2 +-
> include/asm-generic/Kbuild | 1 +
> 9 files changed, 2 insertions(+), 8 deletions(-)
I applied these to pci/msi for v5.5, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread