From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v6 02/19] kernel: Define gettimeofday vdso common code Date: Tue, 4 Jun 2019 13:08:35 +0100 Message-ID: References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-3-vincenzo.frascino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arch , Linux ARM , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies List-Id: linux-arch.vger.kernel.org On 31/05/2019 09:19, Arnd Bergmann wrote: > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino > wrote: > >> + >> +static __always_inline notrace void vdso_write_end(struct vdso_data *vd) >> +{ > > Rather than marking every single function in here as "notrace",I think it > would be more robust to remove the '-pg' flag in the CFLAGS used for > compiling the vdso files. > All the architectures that I added to this patchset are already compiled with $(CC_FLAGS_FTRACE), hence I think I just forgot to remove the "notrace" around the code. Will fix in v7. > Arnd > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:41574 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbfFDMIk (ORCPT ); Tue, 4 Jun 2019 08:08:40 -0400 Subject: Re: [PATCH v6 02/19] kernel: Define gettimeofday vdso common code References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-3-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Tue, 4 Jun 2019 13:08:35 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch , Linux ARM , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies Message-ID: <20190604120835.g2zYsw1PSOvhfljJ_da-VAANWhEb209iAr1l53o2_v8@z> On 31/05/2019 09:19, Arnd Bergmann wrote: > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino > wrote: > >> + >> +static __always_inline notrace void vdso_write_end(struct vdso_data *vd) >> +{ > > Rather than marking every single function in here as "notrace",I think it > would be more robust to remove the '-pg' flag in the CFLAGS used for > compiling the vdso files. > All the architectures that I added to this patchset are already compiled with $(CC_FLAGS_FTRACE), hence I think I just forgot to remove the "notrace" around the code. Will fix in v7. > Arnd > -- Regards, Vincenzo