From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [PATCH v7 03/14] x86/cet/ibt: Add IBT legacy code bitmap setup function Date: Mon, 10 Jun 2019 09:03:04 -0700 Message-ID: References: <20190606200926.4029-1-yu-cheng.yu@intel.com> <20190606200926.4029-4-yu-cheng.yu@intel.com> <20190607080832.GT3419@hirez.programming.kicks-ass.net> <20190607174336.GM3436@hirez.programming.kicks-ass.net> <34E0D316-552A-401C-ABAA-5584B5BC98C5@amacapital.net> <7e0b97bf1fbe6ff20653a8e4e147c6285cc5552d.camel@intel.com> <4b448cde-ee4e-1c95-0f7f-4fe694be7db6@intel.com> <0e505563f7dae3849b57fb327f578f41b760b6f7.camel@intel.com> <4F7D0C3C-F239-4B67-BB05-31350F809293@amacapital.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <4F7D0C3C-F239-4B67-BB05-31350F809293@amacapital.net> Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski , Dave Hansen Cc: Peter Zijlstra , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit List-Id: linux-arch.vger.kernel.org On Fri, 2019-06-07 at 15:27 -0700, Andy Lutomirski wrote: > > On Jun 7, 2019, at 2:09 PM, Dave Hansen wrote: > > > > On 6/7/19 1:06 PM, Yu-cheng Yu wrote: > > > > Huh, how does glibc know about all possible past and future legacy code > > > > in the application? > > > > > > When dlopen() gets a legacy binary and the policy allows that, it will > > > manage > > > the bitmap: > > > > > > If a bitmap has not been created, create one. > > > Set bits for the legacy code being loaded. > > > > I was thinking about code that doesn't go through GLIBC like JITs. > > CRIU is another consideration: it would be rather annoying if CET programs > can’t migrate between LA57 and normal machines. When a machine migrates, does its applications' addresses change? If no, then the bitmap should still work, right? Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:21107 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389178AbfFJQLL (ORCPT ); Mon, 10 Jun 2019 12:11:11 -0400 Message-ID: Subject: Re: [PATCH v7 03/14] x86/cet/ibt: Add IBT legacy code bitmap setup function From: Yu-cheng Yu Date: Mon, 10 Jun 2019 09:03:04 -0700 In-Reply-To: <4F7D0C3C-F239-4B67-BB05-31350F809293@amacapital.net> References: <20190606200926.4029-1-yu-cheng.yu@intel.com> <20190606200926.4029-4-yu-cheng.yu@intel.com> <20190607080832.GT3419@hirez.programming.kicks-ass.net> <20190607174336.GM3436@hirez.programming.kicks-ass.net> <34E0D316-552A-401C-ABAA-5584B5BC98C5@amacapital.net> <7e0b97bf1fbe6ff20653a8e4e147c6285cc5552d.camel@intel.com> <4b448cde-ee4e-1c95-0f7f-4fe694be7db6@intel.com> <0e505563f7dae3849b57fb327f578f41b760b6f7.camel@intel.com> <4F7D0C3C-F239-4B67-BB05-31350F809293@amacapital.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Lutomirski , Dave Hansen Cc: Peter Zijlstra , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin Message-ID: <20190610160304.YYTyec8o9NEeqoMZZGTH9q43w8t0rl55eVOIGooZpLc@z> On Fri, 2019-06-07 at 15:27 -0700, Andy Lutomirski wrote: > > On Jun 7, 2019, at 2:09 PM, Dave Hansen wrote: > > > > On 6/7/19 1:06 PM, Yu-cheng Yu wrote: > > > > Huh, how does glibc know about all possible past and future legacy code > > > > in the application? > > > > > > When dlopen() gets a legacy binary and the policy allows that, it will > > > manage > > > the bitmap: > > > > > > If a bitmap has not been created, create one. > > > Set bits for the legacy code being loaded. > > > > I was thinking about code that doesn't go through GLIBC like JITs. > > CRIU is another consideration: it would be rather annoying if CET programs > can’t migrate between LA57 and normal machines. When a machine migrates, does its applications' addresses change? If no, then the bitmap should still work, right? Yu-cheng