Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asm-generic: Replace __ASSEMBLY__ with __ASSEMBLER__ in uapi headers
Date: Tue, 22 Sep 2026 08:14:27 +0200	[thread overview]
Message-ID: <d6bda4dd-7055-47a6-85b8-9e2afb70614f@redhat.com> (raw)
In-Reply-To: <20260821103425.246901-1-thuth@redhat.com>

On 21/08/2026 12.34, Thomas Huth wrote:
> __ASSEMBLY__ is only defined by the Makefile of the kernel, so
> this is not really useful for uapi headers (unless the userspace
> Makefile defines it, too). Let's switch to __ASSEMBLER__ which
> gets set automatically by the compiler when compiling assembly
> code.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   Note: This has been split from an earlier bigger patch of mine into
>         this separate patch to ease reviewing
> 
>   include/uapi/asm-generic/int-l64.h     | 4 ++--
>   include/uapi/asm-generic/int-ll64.h    | 4 ++--
>   include/uapi/asm-generic/signal-defs.h | 2 +-
>   include/uapi/asm-generic/signal.h      | 4 ++--
>   4 files changed, 7 insertions(+), 7 deletions(-)

Friendly ping?

> diff --git a/include/uapi/asm-generic/int-l64.h b/include/uapi/asm-generic/int-l64.h
> index ed8bcd99c34d7..f840806bbe7e9 100644
> --- a/include/uapi/asm-generic/int-l64.h
> +++ b/include/uapi/asm-generic/int-l64.h
> @@ -11,7 +11,7 @@
>   
>   #include <asm/bitsperlong.h>
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   /*
>    * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the
>    * header files exported to user space
> @@ -29,7 +29,7 @@ typedef unsigned int __u32;
>   typedef __signed__ long __s64;
>   typedef unsigned long __u64;
>   
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   
>   
>   #endif /* _UAPI_ASM_GENERIC_INT_L64_H */
> diff --git a/include/uapi/asm-generic/int-ll64.h b/include/uapi/asm-generic/int-ll64.h
> index 1ed06964257c3..4fc3e882bcff9 100644
> --- a/include/uapi/asm-generic/int-ll64.h
> +++ b/include/uapi/asm-generic/int-ll64.h
> @@ -11,7 +11,7 @@
>   
>   #include <asm/bitsperlong.h>
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   /*
>    * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the
>    * header files exported to user space
> @@ -34,7 +34,7 @@ typedef __signed__ long long __s64;
>   typedef unsigned long long __u64;
>   #endif
>   
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   
>   
>   #endif /* _UAPI_ASM_GENERIC_INT_LL64_H */
> diff --git a/include/uapi/asm-generic/signal-defs.h b/include/uapi/asm-generic/signal-defs.h
> index 7572f2f46ee89..4073143fa3dae 100644
> --- a/include/uapi/asm-generic/signal-defs.h
> +++ b/include/uapi/asm-generic/signal-defs.h
> @@ -78,7 +78,7 @@
>   #define SIG_SETMASK        2	/* for setting the signal mask */
>   #endif
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   typedef void __signalfn_t(int);
>   typedef __signalfn_t __user *__sighandler_t;
>   
> diff --git a/include/uapi/asm-generic/signal.h b/include/uapi/asm-generic/signal.h
> index 0eb69dc8e5722..6b089d4b2965b 100644
> --- a/include/uapi/asm-generic/signal.h
> +++ b/include/uapi/asm-generic/signal.h
> @@ -57,7 +57,7 @@
>   #define SIGSTKSZ	8192
>   #endif
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   typedef struct {
>   	unsigned long sig[_NSIG_WORDS];
>   } sigset_t;
> @@ -88,6 +88,6 @@ typedef struct sigaltstack {
>   	__kernel_size_t ss_size;
>   } stack_t;
>   
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   
>   #endif /* _UAPI__ASM_GENERIC_SIGNAL_H */


      reply	other threads:[~2026-09-22  6:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 10:34 [PATCH] asm-generic: Replace __ASSEMBLY__ with __ASSEMBLER__ in uapi headers Thomas Huth
2026-09-22  6:14 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6bda4dd-7055-47a6-85b8-9e2afb70614f@redhat.com \
    --to=thuth@redhat.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox