From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=13.77.154.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794945431; b=wGhAJel64EPgW/1jgu4rJuXO9ANgN85XGROgP86sN1NzKWbKPcxh2x/OJ2gd9WVtaIaQ YeZcJNhaf1TepddiDzrijTxil8O6ircuZ8EQZZlM/isx35eVChbjCkbrE1aC1NxnDu5MV HB0SaaZyMcNTDmYcxZKc8A+wUrTSamiHW2TUr+lpjAwuO8QN9OHxGr+b2J/3GIAcEXwNK zm+de3mNT/6Qdn5OqTkmNqeZMlHBa2hyUYxLG1380iR7h2FL0FgEFWVJ5apVyeckgWw49 tbAwDM3QKWILNundSvnadJgg5M4Pgf1K1LKv1KGrz6A0tE0oaoQJ1xWRHvzNnaStI/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794945431; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Message-ID:Date: MIME-Version:User-Agent:Subject:Content-Language:To:Cc:References: From:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Spam-Status: X-Spam-Checker-Version; bh=mS6U6LNFb4xUzBlWKPMaUzCqy2fRWteDoRLNvJCa/aE=; b=bzBSJqzFwepQLca18Ih1tw0QV/0Ybc8+D5txqufm40ci6U6mXAfWkAxWm4w26j9xGBO4 axs8JG8tyCVPa+J0sxTkXKAyNOH6zkmu7y4uaBvLDNMQRnauJVm/lLRm4yJ6uIaovkhXJ rLdg3pDd/mVWFNZAuQl0w8OXGBM8k6t/USQp8P7vLljA9GI0HPLMCJQVamQ8IeKEPVJr4 q9Pn3jIHPVUgs9YXYARNbbvjkD2aThUkH2BuXN/MtMVISyzr1z3kFuApN+iVSUJ15RBCX Qrsq4vd0ZNl//P8pTAodojnMNVQHgpY+jMcnufxuvcglZUXCSbXE3aCQRttFpv3l2iw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b="kSXbK6/f"; arc=none smtp.remote-ip=13.77.154.182 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6938606A32C; Tue, 17 Nov 2026 19:57:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C6938606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=kSXbK6/f Received: from [192.168.0.88] (192-184-212-33.fiber.dynamic.sonic.net [192.184.212.33]) by linux.microsoft.com (Postfix) with ESMTPSA id 18F6C20B7169; Tue, 17 Nov 2026 11:57:09 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 18F6C20B7169 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1794945429; bh=mS6U6LNFb4xUzBlWKPMaUzCqy2fRWteDoRLNvJCa/aE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kSXbK6/fN2QDV23Qjqbs8/OUmmbD3O4z81UUHQrMLbQY+AdMTueM0/0y9dfc2WXnS h5jlSN0sD6tl/ZiG4Kxqf8TVubjAuyodGw2O5Th2GH+ehC6i1XZF2mJ7+gDp13a7A0 DWVDFNiwpLGYD6N4SZP+LZ/yqlx+3JZx4TJ8QjQU= Message-ID: Date: Tue, 17 Nov 2026 11:57:08 -0800 X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v6 4/6] Drivers: hv: Mark shared memory as decrypted for CCA Realms Content-Language: en-US To: Kameron Carr Cc: Michael Kelley , "decui@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "arnd@arndb.de" , "catalin.marinas@arm.com" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lpieralisi@kernel.org" , "mark.rutland@arm.com" , "sudeep.holla@kernel.org" , "thuth@redhat.com" , "will@kernel.org" References: <20261031001412.4150488-1-kameroncarr@linux.microsoft.com> <20261031001412.4150488-5-kameroncarr@linux.microsoft.com> <7ebf7187-bf42-fc11-e89b-b1aba96539d2@linux.microsoft.com> <5fddb57c-8805-4fbd-9e27-1c8654f29436@linux.microsoft.com> From: Mukesh R In-Reply-To: <5fddb57c-8805-4fbd-9e27-1c8654f29436@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/16/26 11:53, Kameron Carr wrote: > On 11/13/2026 6:59 PM, Mukesh R wrote: >> On 11/12/26 16:46, Mukesh R wrote: >>> On 11/12/26 09:49, Kameron Carr wrote: >>>> On 11/11/2026 6:43 PM, Mukesh R wrote: >>>>> On 11/11/26 10:01, Michael Kelley wrote: >>>>>> From: Kameron Carr Sent: Friday, October 30, 2026 5:14 PM >>>>>>> >>>>>>> In hv_common_cpu_init(), the per-CPU hypercall input/output pages need >>>>>>> to be marked as decrypted (shared) for confidential VM isolation types. >>>>>>> This is already done for SNP and TDX isolation; extend the same handling >>>>>>> to Arm CCA Realm guests so that the host hypervisor can access the >>>>>>> shared hypercall buffers. >>>>>>> >>>>>>> is_realm_world() is declared in include/linux/arm-rsi-cmds.h which only >>>>>>> builds on arm64 (it includes ), so using it directly in >>>>>>> the arch-neutral drivers/hv/hv_common.c would break the x86 build. >>>>>>> Introduce a Hyper-V-specific helper following the established >>>>>>> hv_isolation_type_snp() / hv_isolation_type_tdx() pattern. >>>>>>> >>>>>>> On architectures other than arm64 the weak default keeps the existing >>>>>>> behaviour. >>>>>>> >>>>>>> Reviewed-by: Michael Kelley >>>>>>> Signed-off-by: Kameron Carr >>>>>>> --- >>>>>>> arch/arm64/hyperv/mshyperv.c | 5 +++++ >>>>>>> drivers/hv/hv_common.c | 17 +++++++++++++---- >>>>>>> include/asm-generic/mshyperv.h | 1 + >>>>>>> 3 files changed, 19 insertions(+), 4 deletions(-) >>>>>>> >>>>>>> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c >>>>>>> index 46ab2da..da6c3aa0 100644 >>>>>>> --- a/arch/arm64/hyperv/mshyperv.c >>>>>>> +++ b/arch/arm64/hyperv/mshyperv.c >>>>>>> @@ -182,3 +182,8 @@ bool hv_is_hyperv_initialized(void) >>>>>>> return hyperv_initialized; >>>>>>> } >>>>>>> EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized); >>>>>>> + >>>>>>> +bool hv_isolation_type_cca(void) >>>>>>> +{ >>>>>>> + return is_realm_world(); >>>>>>> +} >>>>>>> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c >>>>>>> index 31256cb..a60c92c 100644 >>>>>>> --- a/drivers/hv/hv_common.c >>>>>>> +++ b/drivers/hv/hv_common.c >>>>>>> @@ -476,6 +476,7 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>> u64 msr_vp_index; >>>>>>> gfp_t flags; >>>>>>> const int pgcount = hv_output_page_exists() ? 2 : 1; >>>>>>> + const size_t alloc_size = ALIGN((size_t)pgcount * HV_HYP_PAGE_SIZE, PAGE_SIZE); >>>>>>> void *mem; >>>>>>> int ret = 0; >>>>>>> >>>>>>> @@ -489,7 +490,7 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>> * online and then taken offline >>>>>>> */ >>>>>>> if (!*inputarg) { >>>>>>> - mem = kmalloc_array(pgcount, HV_HYP_PAGE_SIZE, flags); >>>>>>> + mem = kmalloc(alloc_size, flags); >>>>>>> if (!mem) >>>>>>> return -ENOMEM; >>>>>>> >>>>>>> @@ -499,14 +500,16 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>> } >>>>>>> >>>>>>> if (!ms_hyperv.paravisor_present && >>>>>>> - (hv_isolation_type_snp() || hv_isolation_type_tdx())) { >>>>>>> - ret = set_memory_decrypted((unsigned long)mem, pgcount); >>>>>>> + (hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>>>>> + hv_isolation_type_cca())) { >>>>>> >>>>>> Could this big "if" statement use "hv_is_isolation_supported()" instead >>>>>> of explicitly testing for each CoCo VM type? I ask partly because >>>>>> Mukesh Rathor has just submitted a patch [1] that introduces a new >>>>>> function that does something almost exactly the same as >>>>>> hv_is_isolation_supported() and uses it here. >>>>> >>>>>>> + (hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>>>>> + hv_isolation_type_cca())) { >>>>> >>>>> With my change, this will become: >>>>> >>>>> (hv_isolation_hw_cvm() || hv_isolation_type_cca())) { >>>> >>>> Any reason you wouldn't change hv_isolation_hw_cvm() to >>>> >>>> return hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>> hv_isolation_type_cca() >>>> >>>> That would seem more logical to me. >>>> >>> >>> We could, I just don't know if on cca, the repeat hypercall has same >>> behavior. I was leaving that for the arm team. Anyways, I sent question >>> to the hyp team, if they say yes, i can update my patch to include that. >>> >>> Thanks, >>> -Mukesh >> >> >> Confirming, arm has same behavior and needs the fix also. So, we can def >> expand the check to include _cca. >> >> I just sent V1, renaming hv_isolation_hw_cvm() to hv_isolation_type_hw(). >> If your patch goes after mine, you just need to add to your 0004*: >> >> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c >> index 4fdc26ade1d7..67a16b4d2235 100644 >> --- a/arch/arm64/hyperv/mshyperv.c >> +++ b/arch/arm64/hyperv/mshyperv.c >> @@ -134,3 +134,8 @@ bool hv_is_hyperv_initialized(void) >> return hyperv_initialized; >> } >> EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized); >> + >> +bool hv_isolation_type_hw(void) >> +{ >> + return is_realm_world(); >> +} >> >> >> OR, you could pick mine 0001-* and make it part of your series, and I >> can drop it from mine and make it dependent on yours. But mine is small >> enough that it has higher chances of going in first..... >> > > This patch set has already been applied to hyperv-next, so maybe you can > rebase off that. > Ok, I'll rebase my patches from hyperv-fixes to hyperv-next, and resubmit. Thanks, -Mukesh