Re: [PATCH V2 0/2] uapi: Add support for GENMASK_U128()

Arnd Bergmann
2024-07-30T12:30:09Z

On Tue, Jul 30, 2024, at 06:29, Anshuman Khandual wrote:
> On 7/25/24 11:18, Anshuman Khandual wrote:
>>
>> - Wrapped genmask_u128_test() with CONFIG_ARCH_SUPPORTS_INT128
>> - Defined __BITS_PER_U128 unconditionally as 128
>> - Defined __GENMASK_U128() via new _BIT128()
>> - Dropped _U128() and _AC128()
>
> Does the changed series look good ? Please do let me know if something
> further needs to be changed. Thank you.

Yes, these look fine to me, please add

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

One detail: You are not actually using __BITS_PER_U128 at
all now, so I think it would be better to not add it at all.