Re: [PATCH V2 0/2] uapi: Add support for GENMASK_U128()

Anshuman Khandual
2024-07-31T02:39:40Z

On 7/30/24 17:59, Arnd Bergmann wrote:
> On Tue, Jul 30, 2024, at 06:29, Anshuman Khandual wrote:
>> On 7/25/24 11:18, Anshuman Khandual wrote:
>>>
>>> - Wrapped genmask_u128_test() with CONFIG_ARCH_SUPPORTS_INT128
>>> - Defined __BITS_PER_U128 unconditionally as 128
>>> - Defined __GENMASK_U128() via new _BIT128()
>>> - Dropped _U128() and _AC128()
>>
>> Does the changed series look good ? Please do let me know if something
>> further needs to be changed. Thank you.
>
> Yes, these look fine to me, please add
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd.

>
> One detail: You are not actually using __BITS_PER_U128 at
> all now, so I think it would be better to not add it at all.

Sure, will do, missed that some how.