From: "Rolf Eike Beer" <eike-kernel@sf-tec.de>
Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
bheglaas@google.com, monstr@monstr.eu, tglx@linutronix.de,
bigeasy@linutronix.de,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 3/6] microblaze/pci: Move the remains of pci_32.c to pci-common.c
Date: Mon, 11 Apr 2011 15:12:15 -0000 [thread overview]
Message-ID: <da7a8b1fa75c0968a4586a591713d5db.squirrel@webmail.sf-mail.de> (raw)
In-Reply-To: <1302495170-973-4-git-send-email-benh@kernel.crashing.org>
> There's no point in keeping this separate. Even if microblaze grows
> a 64-bit variant, it will probably be able to re-use that code as-is
> diff --git a/arch/microblaze/pci/pci-common.c
> b/arch/microblaze/pci/pci-common.c
> index 5359906..041b1d8 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -50,6 +50,11 @@ unsigned int pci_flags;
>
> static struct dma_map_ops *pci_dma_ops = &dma_direct_ops;
>
> +unsigned long isa_io_base;
> +unsigned long pci_dram_offset;
> +static int pci_bus_count;
> +
> +
Extra newline.
Eike
WARNING: multiple messages have this Message-ID (diff)
From: "Rolf Eike Beer" <eike-kernel@sf-tec.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
bheglaas@google.com, monstr@monstr.eu, tglx@linutronix.de,
bigeasy@linutronix.de
Subject: Re: [PATCH 3/6] microblaze/pci: Move the remains of pci_32.c to pci-common.c
Date: Mon, 11 Apr 2011 15:12:15 -0000 [thread overview]
Message-ID: <da7a8b1fa75c0968a4586a591713d5db.squirrel@webmail.sf-mail.de> (raw)
Message-ID: <20110411151215.Z-N4l2x9JxfGbM-rnn_-d6DfUsoIJW59M8HH-mkDDVM@z> (raw)
In-Reply-To: <1302495170-973-4-git-send-email-benh@kernel.crashing.org>
> There's no point in keeping this separate. Even if microblaze grows
> a 64-bit variant, it will probably be able to re-use that code as-is
> diff --git a/arch/microblaze/pci/pci-common.c
> b/arch/microblaze/pci/pci-common.c
> index 5359906..041b1d8 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -50,6 +50,11 @@ unsigned int pci_flags;
>
> static struct dma_map_ops *pci_dma_ops = &dma_direct_ops;
>
> +unsigned long isa_io_base;
> +unsigned long pci_dram_offset;
> +static int pci_bus_count;
> +
> +
Extra newline.
Eike
next prev parent reply other threads:[~2011-04-11 15:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 4:12 [PATCHES v3] pci/of: Generic PCI <-> OF matching Benjamin Herrenschmidt
2011-04-11 4:12 ` [PATCH 1/6] pci/of: Match PCI devices to OF nodes dynamically Benjamin Herrenschmidt
2011-04-19 5:19 ` Grant Likely
2011-04-11 4:12 ` [PATCH 2/6] microblaze/pci: Remove powermac originated cruft Benjamin Herrenschmidt
2011-04-11 4:12 ` Benjamin Herrenschmidt
2011-04-11 4:12 ` [PATCH 3/6] microblaze/pci: Move the remains of pci_32.c to pci-common.c Benjamin Herrenschmidt
2011-04-11 15:12 ` Rolf Eike Beer [this message]
2011-04-11 15:12 ` Rolf Eike Beer
2011-04-11 21:25 ` Benjamin Herrenschmidt
2011-04-11 4:12 ` [PATCH 4/6] x86/devicetree: Use generic PCI <-> OF matching Benjamin Herrenschmidt
2011-04-11 4:12 ` Benjamin Herrenschmidt
2011-04-11 4:12 ` [PATCH 5/6] pci/of: Consolidate pci_device_to_OF_node() Benjamin Herrenschmidt
2011-04-11 4:12 ` Benjamin Herrenschmidt
2011-04-11 4:12 ` [PATCH 6/6] pci/of: Consolidate pci_bus_to_OF_node() Benjamin Herrenschmidt
2011-04-19 5:24 ` Grant Likely
2011-04-12 8:53 ` [PATCHES v3] pci/of: Generic PCI <-> OF matching Sebastian Andrzej Siewior
2011-04-12 8:53 ` Sebastian Andrzej Siewior
2011-04-19 5:58 ` Michal Simek
2011-06-07 5:58 ` Benjamin Herrenschmidt
2011-06-07 16:05 ` Jesse Barnes
2011-06-07 16:05 ` Jesse Barnes
2011-06-07 21:37 ` Benjamin Herrenschmidt
2011-06-07 21:37 ` Benjamin Herrenschmidt
2011-06-08 0:06 ` Benjamin Herrenschmidt
2011-06-08 0:28 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da7a8b1fa75c0968a4586a591713d5db.squirrel@webmail.sf-mail.de \
--to=eike-kernel@sf-tec.de \
--cc=benh@kernel.crashing.org \
--cc=bheglaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).