From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([144.76.43.62]:39184 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfKZInp (ORCPT ); Tue, 26 Nov 2019 03:43:45 -0500 Message-ID: Subject: Re: [RFC v2 17/37] lkl tools: host lib: virtio devices From: Johannes Berg Date: Tue, 26 Nov 2019 09:43:36 +0100 In-Reply-To: References: <1531c5f16a00b608635c9a62fa3951807075f950.1573179553.git.thehajime@gmail.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Weinberger , Hajime Tazaki Cc: Linux-Arch , Conrad Meyer , Octavian Purdila , linux-um@lists.infradead.org, Akira Moroo , linux-kernel-library@freelists.org, Patrick Collins , Michael Zimmermann , Yuan Liu On Mon, 2019-11-25 at 23:07 +0100, Richard Weinberger wrote: > On Fri, Nov 8, 2019 at 6:03 AM Hajime Tazaki wrote: > > From: Octavian Purdila > > > > Add helpers for implementing host virtio devices. It uses the memory > > mapped I/O helpers to interact with the Linux MMIO virtio transport > > driver and offers support to setup and add a new virtio device, > > dispatch requests from the incoming queues as well as support for > > completing requests. > > > > All added virtio devices are stored in lkl_virtio_devs as strings, per > > the Linux MMIO virtio transport driver command line specification. > > Did you checkout arch/um/drivers/virtio_uml.c? > Why is this driver needed? This isn't really a driver, this is virtio *device-side* code. Our virtio_uml is *guest-side* code, and only speaks vhost-user. I'm not sure how MMIO devices could possibly work though, does LKL intercept MMIO somehow? johannes