[PATCH] vdso/gettimeofday: Fix code refactoring

[PATCH] vdso/gettimeofday: Fix code refactoring

[Marek Szyprowski]

Commit fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime()
helpers") changed the return value from clock_gettime() helpers, but it
missed updating the one call to the do_hres() function, what breaks VDSO
operation on some of my ARM 32bit based test boards. Fix this.

Fixes: fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime() helpers")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 lib/vdso/gettimeofday.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index d6743ed756a1..97aa9059a5c9 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -395,7 +395,7 @@ __cvdso_gettimeofday_data(const struct vdso_time_data *vd,
 	if (likely(tv != NULL)) {
 		struct __kernel_timespec ts;
 
-		if (do_hres(vd, &vc[CS_HRES_COARSE], CLOCK_REALTIME, &ts))
+		if (!do_hres(vd, &vc[CS_HRES_COARSE], CLOCK_REALTIME, &ts))
 			return gettimeofday_fallback(tv, tz);
 
 		tv->tv_sec = ts.tv_sec;
-- 
2.34.1

Re: [PATCH] vdso/gettimeofday: Fix code refactoring

[Thomas Weißschuh]

Hi Marek,

On Thu, Jul 10, 2025 at 08:22:49AM +0200, Marek Szyprowski wrote:
> Commit fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime()
> helpers") changed the return value from clock_gettime() helpers, but it
> missed updating the one call to the do_hres() function, what breaks VDSO
> operation on some of my ARM 32bit based test boards. Fix this.

Thanks again for the report and fix.
This change has already been folded into the original commit by tglx.
It should show up in todays -next tree.

> Fixes: fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime() helpers")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Thomas

Re: [PATCH] vdso/gettimeofday: Fix code refactoring

[Marek Szyprowski]

On 10.07.2025 08:45, Thomas Weißschuh wrote:
> On Thu, Jul 10, 2025 at 08:22:49AM +0200, Marek Szyprowski wrote:
>> Commit fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime()
>> helpers") changed the return value from clock_gettime() helpers, but it
>> missed updating the one call to the do_hres() function, what breaks VDSO
>> operation on some of my ARM 32bit based test boards. Fix this.
> Thanks again for the report and fix.
> This change has already been folded into the original commit by tglx.
> It should show up in todays -next tree.

Okay. I got no information about that, so I decided to send a patch just 
in case.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland