From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Zigotzky Subject: Re: use generic DMA mapping code in powerpc V4 Date: Thu, 13 Dec 2018 14:34:49 +0100 Message-ID: References: <1ecb7692-f3fb-a246-91f9-2db1b9496305@xenosoft.de> <6c997c03-e072-97a9-8ae0-38a4363df919@xenosoft.de> <4cfb3f26-74e1-db01-b014-759f188bb5a6@xenosoft.de> <82879d3f-83de-6438-c1d6-49c571dcb671@xenosoft.de> <20181212141556.GA4801@lst.de> <2242B4B2-6311-492E-BFF9-6740E36EC6D4@xenosoft.de> <84558d7f-5a7f-5219-0c3a-045e6b4c494f@xenosoft.de> <20181213091021.GA2106@lst.de> <835bd119-081e-a5ea-1899-189d439c83d6@xenosoft.de> <76bc684a-b4d2-1d26-f18d-f5c9ba65978c@xenosoft.de> <20181213112511.GA4574@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181213112511.GA4574@lst.de> Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On 13 December 2018 at 12:25PM, Christoph Hellwig wrote: > On Thu, Dec 13, 2018 at 12:19:26PM +0100, Christian Zigotzky wrote: >> I tried it again but I get the following error message: >> >> MODPOST vmlinux.o >> arch/powerpc/kernel/dma-iommu.o: In function `.dma_iommu_get_required_mask': >> (.text+0x274): undefined reference to `.dma_direct_get_required_mask' >> make: *** [vmlinux] Error 1 > Sorry, you need this one liner before all the patches posted last time: > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index d8819e3a1eb1..7e78c2798f2f 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -154,6 +154,7 @@ config PPC > select CLONE_BACKWARDS > select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN > select DYNAMIC_FTRACE if FUNCTION_TRACER > + select DMA_DIRECT_OPS > select EDAC_ATOMIC_SCRUB > select EDAC_SUPPORT > select GENERIC_ATOMIC64 if PPC32 > Thanks. Result: PASEMI onboard ethernet works and the X5000 (P5020 board) boots with the patch '0001-get_required_mask.patch'. -- Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:25496 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729281AbeLMNey (ORCPT ); Thu, 13 Dec 2018 08:34:54 -0500 Subject: Re: use generic DMA mapping code in powerpc V4 References: <1ecb7692-f3fb-a246-91f9-2db1b9496305@xenosoft.de> <6c997c03-e072-97a9-8ae0-38a4363df919@xenosoft.de> <4cfb3f26-74e1-db01-b014-759f188bb5a6@xenosoft.de> <82879d3f-83de-6438-c1d6-49c571dcb671@xenosoft.de> <20181212141556.GA4801@lst.de> <2242B4B2-6311-492E-BFF9-6740E36EC6D4@xenosoft.de> <84558d7f-5a7f-5219-0c3a-045e6b4c494f@xenosoft.de> <20181213091021.GA2106@lst.de> <835bd119-081e-a5ea-1899-189d439c83d6@xenosoft.de> <76bc684a-b4d2-1d26-f18d-f5c9ba65978c@xenosoft.de> <20181213112511.GA4574@lst.de> From: Christian Zigotzky Message-ID: Date: Thu, 13 Dec 2018 14:34:49 +0100 MIME-Version: 1.0 In-Reply-To: <20181213112511.GA4574@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org Message-ID: <20181213133449.jpv8m0u4P0wmQZrqQoPGMtQ11IjFpNwEDuoQsc17ksQ@z> On 13 December 2018 at 12:25PM, Christoph Hellwig wrote: > On Thu, Dec 13, 2018 at 12:19:26PM +0100, Christian Zigotzky wrote: >> I tried it again but I get the following error message: >> >> MODPOST vmlinux.o >> arch/powerpc/kernel/dma-iommu.o: In function `.dma_iommu_get_required_mask': >> (.text+0x274): undefined reference to `.dma_direct_get_required_mask' >> make: *** [vmlinux] Error 1 > Sorry, you need this one liner before all the patches posted last time: > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index d8819e3a1eb1..7e78c2798f2f 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -154,6 +154,7 @@ config PPC > select CLONE_BACKWARDS > select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN > select DYNAMIC_FTRACE if FUNCTION_TRACER > + select DMA_DIRECT_OPS > select EDAC_ATOMIC_SCRUB > select EDAC_SUPPORT > select GENERIC_ATOMIC64 if PPC32 > Thanks. Result: PASEMI onboard ethernet works and the X5000 (P5020 board) boots with the patch '0001-get_required_mask.patch'. -- Christian