From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [REVIEW][PATCH 12/20] signal/x86: Remove pkey parameter from bad_area_nosemaphore Date: Wed, 19 Sep 2018 09:33:42 -0700 Message-ID: References: <87y3bzk6yv.fsf@xmission.com> <20180918000546.12552-12-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner , "Eric W. Biederman" Cc: LKML , linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org List-Id: linux-arch.vger.kernel.org On 09/18/2018 01:44 PM, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Eric W. Biederman wrote: >> The function bad_area_nosemaphore always sets si_code to SEGV_MAPERR >> and as such can never return a pkey parameter. Therefore remove the >> unusable pkey parameter from bad_area_nosemaphore. The result of this looks nice to me. It's especially nice to see the scope where we have to pass around the pkey get reduced. I also ran the pkey selftests against the current version of your siginfo-testing branch. Everything passes fine on my pkey-enabled system. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:15628 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731630AbeISWMZ (ORCPT ); Wed, 19 Sep 2018 18:12:25 -0400 Subject: Re: [REVIEW][PATCH 12/20] signal/x86: Remove pkey parameter from bad_area_nosemaphore References: <87y3bzk6yv.fsf@xmission.com> <20180918000546.12552-12-ebiederm@xmission.com> From: Dave Hansen Message-ID: Date: Wed, 19 Sep 2018 09:33:42 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner , "Eric W. Biederman" Cc: LKML , linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org Message-ID: <20180919163342.YlFPO_5UOrHgcYtNxjZjeY4oAMzLejHwz9c7RrIwcM4@z> On 09/18/2018 01:44 PM, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Eric W. Biederman wrote: >> The function bad_area_nosemaphore always sets si_code to SEGV_MAPERR >> and as such can never return a pkey parameter. Therefore remove the >> unusable pkey parameter from bad_area_nosemaphore. The result of this looks nice to me. It's especially nice to see the scope where we have to pass around the pkey get reduced. I also ran the pkey selftests against the current version of your siginfo-testing branch. Everything passes fine on my pkey-enabled system.