From: Logan Gunthorpe <logang@deltatee.com>
To: "Horia Geantă" <horia.geanta@nxp.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Bates <sbates@raithlin.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Nicholas Piggin <npiggin@gmail.com>,
Suresh Warrier <warrier@linux.vnet.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>
Subject: Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs
Date: Thu, 20 Jul 2017 09:39:33 -0600 [thread overview]
Message-ID: <edcc1102-d29f-cd19-4103-8ea6719d5f12@deltatee.com> (raw)
In-Reply-To: <VI1PR0401MB259189A76FFD80DC02ACCF8998A70@VI1PR0401MB2591.eurprd04.prod.outlook.com>
On 20/07/17 06:36 AM, Horia Geantă wrote:
> include/asm-generic/iomap.h is included before
> include/linux/io-64-nonatomic-lo-hi.h:
>
> include/linux/io.h -> arch/powerpc/include/asm/io.h ->
> include/asm-generic/iomap.h
>
> Thus, the "extern" version of ioread64_lo_hi and friends will be used
> (and not the inline version from io-64-nonatomic-lo-hi.h).
>
> But for this kernel .config:
> -CONFIG_GENERIC_IOMAP=n and
> -there is no implementation of io{read|write}64[be]{_lo_hi|_hi_lo} in
> arch/powerpc/kernel/iomap.c
Ah, thanks for the triage. I'll take a look at fixing this for a v5.
Logan
next prev parent reply other threads:[~2017-07-20 15:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 16:55 [PATCH v4 0/5] make io{read|write}64 globally usable Logan Gunthorpe
2017-07-18 16:55 ` Logan Gunthorpe
2017-07-18 16:55 ` [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Logan Gunthorpe
2017-07-18 16:55 ` Logan Gunthorpe
2017-07-19 5:57 ` Michael Ellerman
2017-07-19 5:57 ` Michael Ellerman
2017-07-19 16:04 ` Logan Gunthorpe
2017-07-19 16:04 ` Logan Gunthorpe
2017-07-20 10:27 ` Horia Geantă
2017-07-20 10:27 ` Horia Geantă
2017-07-20 12:36 ` Horia Geantă
2017-07-20 12:36 ` Horia Geantă
2017-07-20 15:39 ` Logan Gunthorpe [this message]
2017-07-20 15:39 ` Logan Gunthorpe
2017-07-20 11:10 ` Michael Ellerman
2017-07-18 16:55 ` [PATCH v4 2/5] iomap: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe
2017-07-18 16:55 ` Logan Gunthorpe
2017-07-18 16:55 ` [PATCH v4 3/5] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe
2017-07-18 16:55 ` [PATCH v4 4/5] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe
2017-07-18 16:55 ` Logan Gunthorpe
2017-07-18 17:49 ` Allen Hubbe
2017-07-18 17:49 ` Allen Hubbe
2017-07-18 16:55 ` [PATCH v4 5/5] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2017-07-18 16:55 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edcc1102-d29f-cd19-4103-8ea6719d5f12@deltatee.com \
--to=logang@deltatee.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=sbates@raithlin.com \
--cc=warrier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).