From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [PATCH] bug.h: Work around GCC PR82365 in BUG() Date: Tue, 19 Dec 2017 14:38:21 -0800 Message-ID: References: <20171219114112.939391-1-arnd@arndb.de> <8e42a1de-f619-7a4e-6d58-f90f53f5f38f@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-ia64-owner@vger.kernel.org To: Arnd Bergmann Cc: "linux-arch@vger.kernel.org" , Andrew Morton , "linux-kbuild@vger.kernel.org" , Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , Geert Uytterhoeven , "David S. Miller" , Christopher Li , Thomas Gleixner , Peter Zijlstra , Kees Cook , Ingo Molnar , Josh Poimboeuf , Will Deacon , "Steven Rostedt (VMware)" , Mark Rutland , linux-s List-Id: linux-arch.vger.kernel.org On 12/19/2017 12:13 PM, Arnd Bergmann wrote: > >> I suppose BUG() implies "dead end" like semantics - which ARC was lacking >> before ? > Correct. Using __builtin_trap() here avoids the 'control reaches end of non-void > function' warnings, but then makes us run into the stack size problem that > I work around with the barrier_before_unreachable(). > > It would be good if you could give this a quick test to see if you get sensible > output from the __builtin_trap(); It does, added a BUG() arbit, hits an abort() ... ISA Extn    : atomic ll64 unalign (not used)         : mpy[opt 9] div_rem norm barrel-shift swap minmax swape BPU        : partial match, cache:2048, Predict Table:16384 BUG: failure at ../arch/arc/mm/tlb.c:827/arc_mmu_init()! Tested-by: Vineet Gupta FWIW newer ARC gcc actually implements the builtin so we get a trap 5 instruction now, vs., abort() calls before. BTW I missed reading the hunk of your changelog where this addresses the long standing mystery with ARC builds and numerous -Wreturn-type warnings. I always wondered why they were not fixed upstream already, being too lazy to investigate myself, and turns out this was due to this BUG() thingy. phew ! -Vineet From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay2.synopsys.com ([198.182.60.111]:52633 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753401AbdLSWii (ORCPT ); Tue, 19 Dec 2017 17:38:38 -0500 Subject: Re: [PATCH] bug.h: Work around GCC PR82365 in BUG() References: <20171219114112.939391-1-arnd@arndb.de> <8e42a1de-f619-7a4e-6d58-f90f53f5f38f@synopsys.com> From: Vineet Gupta Message-ID: Date: Tue, 19 Dec 2017 14:38:21 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: "linux-arch@vger.kernel.org" , Andrew Morton , "linux-kbuild@vger.kernel.org" , Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , Geert Uytterhoeven , "David S. Miller" , Christopher Li , Thomas Gleixner , Peter Zijlstra , Kees Cook , Ingo Molnar , Josh Poimboeuf , Will Deacon , "Steven Rostedt (VMware)" , Mark Rutland , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-cris-kernel@axis.com" , "linux-ia64@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "sparclinux@vger.kernel.org" , "linux-sparse@vger.kernel.org" Message-ID: <20171219223821.WNHogR8l7l_kM28f78J7rdbVHyzvqjkH01w7TvEpt4s@z> On 12/19/2017 12:13 PM, Arnd Bergmann wrote: > >> I suppose BUG() implies "dead end" like semantics - which ARC was lacking >> before ? > Correct. Using __builtin_trap() here avoids the 'control reaches end of non-void > function' warnings, but then makes us run into the stack size problem that > I work around with the barrier_before_unreachable(). > > It would be good if you could give this a quick test to see if you get sensible > output from the __builtin_trap(); It does, added a BUG() arbit, hits an abort() ... ISA Extn    : atomic ll64 unalign (not used)         : mpy[opt 9] div_rem norm barrel-shift swap minmax swape BPU        : partial match, cache:2048, Predict Table:16384 BUG: failure at ../arch/arc/mm/tlb.c:827/arc_mmu_init()! Tested-by: Vineet Gupta FWIW newer ARC gcc actually implements the builtin so we get a trap 5 instruction now, vs., abort() calls before. BTW I missed reading the hunk of your changelog where this addresses the long standing mystery with ARC builds and numerous -Wreturn-type warnings. I always wondered why they were not fixed upstream already, being too lazy to investigate myself, and turns out this was due to this BUG() thingy. phew ! -Vineet