From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC574C7EE43 for ; Thu, 8 Jun 2023 13:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235151AbjFHNRg (ORCPT ); Thu, 8 Jun 2023 09:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234086AbjFHNRf (ORCPT ); Thu, 8 Jun 2023 09:17:35 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 006FD210C; Thu, 8 Jun 2023 06:17:34 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-653f9c7b3e4so324763b3a.2; Thu, 08 Jun 2023 06:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686230254; x=1688822254; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=yy3Bf+NazHm1oNAREFVNFLHJOT3YLCmd5DpqRQr2VCQ=; b=YUYKox0MBLRcKzjuScabc+6kkVmePNsualolG63lhkSE9quGcrtR2sA5yxUZ6o19Hj HSIEyBTIB8cgjJVS/yCJyA1CONBIelkg8JoYM87R9tSbpkbTgM4ZMZ84BahfkZmoO51K C616u1ZgL/AB0Azp3UMrMFcF7GbqZtQHRTrttbDYcB21RKsmsxKzcP3ZtpNXSWQ1LYsu l1a6UeXBw2U37KrfomB3NmxfEAaG/R0VOXugJzJBMrvQe9lienwSKvMU5P6oQomgALtn 6mVVwaZHNI1B4lVtW2r2IUp3lo1mwiAaory6FbjUU3u+eLookWf7gct8VYBzeTvuq1wx icPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686230254; x=1688822254; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yy3Bf+NazHm1oNAREFVNFLHJOT3YLCmd5DpqRQr2VCQ=; b=dbNZ3pwUnRE6F+FmIarWp+0KA14/Q+p8OJe6ypFJNqKUFVV/cRdPLizrwz+mOFfMUj 85JlTAL1Tbb/ESexjPOEslnUKfM59uxOLCq60+nwLZVsrLFaZ8M3nraT8ChwU9AsNTdh 75ZtOixYctRCxjxUbFUDA8XEccG2TyRS6syaDMuSjdQvyMI1iD5RXVideHTczrgy+XoT rUXCfJDn3BvW26UORqN/j9z9nVHTZQvnErnjTM2ODF9bkPOEC5r2kH+qDeuD9OwpnTiR YOuK45CHDSRwg68s7YsBbleP6awaTHGkpSSdZySdb8NxotV/TY8nayzX08xAQ4iZjc/6 DTAg== X-Gm-Message-State: AC+VfDwdTMiKDcD5gsWN1lA3ggtJJ4nR1dsXxVGw9/B1xBsrI/czykEP fdZue97qv6zpM5XVv5bQd8c= X-Google-Smtp-Source: ACHHUZ7S1sKJGDgwoxI9KIEm3hc0rB9Vq+vwLPT0vdAXyq345EdBOoTexBfh1JnjPXysgOy9EGMe6A== X-Received: by 2002:a17:90b:d85:b0:258:71e6:1c24 with SMTP id bg5-20020a17090b0d8500b0025871e61c24mr5338938pjb.12.1686230254325; Thu, 08 Jun 2023 06:17:34 -0700 (PDT) Received: from ?IPV6:2404:f801:0:5:8000::75b? ([2404:f801:9000:1a:efea::75b]) by smtp.gmail.com with ESMTPSA id mq16-20020a17090b381000b00259980d373dsm3120187pjb.1.2023.06.08.06.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 06:17:33 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 21:17:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/9] x86/hyperv: Add sev-snp enlightened guest static key To: "Michael Kelley (LINUX)" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "daniel.lezcano@linaro.org" , "arnd@arndb.de" Cc: Tianyu Lan , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "vkuznets@redhat.com" References: <20230601151624.1757616-1-ltykernel@gmail.com> <20230601151624.1757616-2-ltykernel@gmail.com> From: Tianyu Lan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On 6/8/2023 8:56 PM, Michael Kelley (LINUX) wrote: >> @ -473,7 +477,7 @@ static void __init ms_hyperv_init_platform(void) >> >> #if IS_ENABLED(CONFIG_HYPERV) >> if ((hv_get_isolation_type() == HV_ISOLATION_TYPE_VBS) || >> - (hv_get_isolation_type() == HV_ISOLATION_TYPE_SNP)) >> + ms_hyperv.paravisor_present) > This test needs to be: > > if ((hv_get_isolation_type() == HV_ISOLATION_TYPE_VBS) || > ((hv_get_isolation_type() == HV_ISOLATION_TYPE_SNP) && > ms_hyperv.paravisor_present) > > We want to call hv_vtom_init() only when running with VBS, or > with SEV-SNP*and* we have a paravisor present. Testing only for > paravisor_present risks confusion with future TDX scenarios. Yes, current paravisor is only available for VBS and SEV-SNP vTOM cases. TDX may also have paravisor support. Will update. Thanks.