From: Kyle Moffett <kyle@moffetthome.net>
To: Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
linux arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: kbuild - introduce support for subdir-ccflags-y
Date: Sat, 18 Apr 2009 23:17:44 -0400 [thread overview]
Message-ID: <f73f7ab80904182017n7f27f49ck48ba200deb99388a@mail.gmail.com> (raw)
In-Reply-To: <20090418180953.GE7148@flint.arm.linux.org.uk>
On Sat, Apr 18, 2009 at 2:09 PM, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Sat, Apr 18, 2009 at 05:07:50PM +0200, Ingo Molnar wrote:
>> * Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>> > On Sat, Apr 18, 2009 at 02:51:59PM +0200, Sam Ravnborg wrote:
>> > > The typical use cases are an architecture or a subsystem that
>> > > decide to cover all files with -Werror.
>> > > Today alpha, mips and sparc uses -Werror in almost all their
>> > > Makefile - with subdir-ccflag-y it is now simpler to do so
>> > > as only the top-level directories needs to be covered.
>> >
>> > Hmm, this won't make sense for ARM. We have things like #warning
>> > and deprecated functions in machine specific headers, and adding
>> > -Werror to the whole of arch/arm/ will result in these causing
>> > builds to fail.
>>
>> This is optional - if you dont want it, you dont set it.
>
> Please read _all_ of my mail, particularly the bit where it talks about
> it being useful for a certain subset.
It's my impression that on x86 it's a config option whether or not to
build with -Werror. You could do the exact same thing with an
internal inverted-logic CONFIG_ARM_ALLOW_WARNINGS option and make all
the boards triggering warnings "select ARM_ALLOW_WARNINGS". Then have
a user-visible config option "ARM_USER_ALLOW_WARNINGS" which also
selects the internal option. That adds some additional kconfig-level
documentation on which subarch combos need some love.
Cheers,
Kyle Moffett
WARNING: multiple messages have this Message-ID (diff)
From: Kyle Moffett <kyle@moffetthome.net>
To: Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
linux arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: kbuild - introduce support for subdir-ccflags-y
Date: Sat, 18 Apr 2009 23:17:44 -0400 [thread overview]
Message-ID: <f73f7ab80904182017n7f27f49ck48ba200deb99388a@mail.gmail.com> (raw)
Message-ID: <20090419031744._KiTMfidKxBQL5b0qxE2AWWFx2ZebihSRtX33ptRTm8@z> (raw)
In-Reply-To: <20090418180953.GE7148@flint.arm.linux.org.uk>
On Sat, Apr 18, 2009 at 2:09 PM, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Sat, Apr 18, 2009 at 05:07:50PM +0200, Ingo Molnar wrote:
>> * Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>> > On Sat, Apr 18, 2009 at 02:51:59PM +0200, Sam Ravnborg wrote:
>> > > The typical use cases are an architecture or a subsystem that
>> > > decide to cover all files with -Werror.
>> > > Today alpha, mips and sparc uses -Werror in almost all their
>> > > Makefile - with subdir-ccflag-y it is now simpler to do so
>> > > as only the top-level directories needs to be covered.
>> >
>> > Hmm, this won't make sense for ARM. We have things like #warning
>> > and deprecated functions in machine specific headers, and adding
>> > -Werror to the whole of arch/arm/ will result in these causing
>> > builds to fail.
>>
>> This is optional - if you dont want it, you dont set it.
>
> Please read _all_ of my mail, particularly the bit where it talks about
> it being useful for a certain subset.
It's my impression that on x86 it's a config option whether or not to
build with -Werror. You could do the exact same thing with an
internal inverted-logic CONFIG_ARM_ALLOW_WARNINGS option and make all
the boards triggering warnings "select ARM_ALLOW_WARNINGS". Then have
a user-visible config option "ARM_USER_ALLOW_WARNINGS" which also
selects the internal option. That adds some additional kconfig-level
documentation on which subarch combos need some love.
Cheers,
Kyle Moffett
next prev parent reply other threads:[~2009-04-19 3:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 12:51 kbuild - introduce support for subdir-ccflags-y Sam Ravnborg
2009-04-18 12:58 ` Russell King
2009-04-18 12:58 ` Russell King
2009-04-18 15:07 ` Ingo Molnar
2009-04-18 15:07 ` Ingo Molnar
2009-04-18 18:09 ` Russell King
2009-04-18 18:09 ` Russell King
2009-04-19 3:17 ` Kyle Moffett [this message]
2009-04-19 3:17 ` Kyle Moffett
2009-04-19 6:28 ` Sam Ravnborg
2009-04-19 8:59 ` Ingo Molnar
2009-04-19 8:59 ` Ingo Molnar
2009-04-18 17:55 ` Sam Ravnborg
2009-04-18 17:55 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73f7ab80904182017n7f27f49ck48ba200deb99388a@mail.gmail.com \
--to=kyle@moffetthome.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox