From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V2 3/6] sh/mm: Stop using pte_ERROR()
Date: Thu, 13 Aug 2026 09:18:22 +0200 [thread overview]
Message-ID: <f7bab5a5-76c9-4856-b314-49f19f54e229@kernel.org> (raw)
In-Reply-To: <azo46amarknescr2uotz77khpt6zakwex7sb52krsvakrzfdlq@qu2t3ahd4m5t>
>>> +}
>>> +
>>> static void set_pte_phys(unsigned long addr, unsigned long phys, pgprot_t prot)
>>> {
>>> pte_t *pte;
>>>
>>> pte = __get_pte_phys(addr);
>>> if (!pte_none(*pte)) {
>>> - pte_ERROR(*pte);
>>> + print_bad_pte(*pte);
>>
>> Maybe similar to my reply to patch #1, actually print something more useful than
>> just "bad pte" ? And possibly also just use ptval_to_str().
>
> Probably #ifdef could be dropped here as ptval_to_str() should be able to
> handle pte with two unsiged long elements in there i.e pte_high, pte_low
> along with standard single unsiged long pte_low format.
Yes, that should just work and clean this up!
--
Cheers,
David
next prev parent reply other threads:[~2026-08-13 7:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 4:21 [RFC V2 0/6] mm: Drop pxd_ERROR() Anshuman Khandual
2026-08-11 4:21 ` [RFC V2 1/6] loongarch/mm: Stop using pte_ERROR() Anshuman Khandual
2026-08-12 11:19 ` David Hildenbrand (Arm)
2026-08-12 11:27 ` David Hildenbrand (Arm)
2026-08-13 4:34 ` Anshuman Khandual
2026-08-11 4:21 ` [RFC V2 2/6] parisc/mm: Directly use generic [pmd|pgd]_clear_bad() Anshuman Khandual
2026-08-12 11:16 ` David Hildenbrand (Arm)
2026-08-11 4:21 ` [RFC V2 3/6] sh/mm: Stop using pte_ERROR() Anshuman Khandual
2026-08-12 11:28 ` David Hildenbrand (Arm)
2026-08-13 5:30 ` Anshuman Khandual
2026-08-13 7:18 ` David Hildenbrand (Arm) [this message]
2026-08-11 4:21 ` [RFC V2 4/6] sh/mm: Stop using [p4d|pud|pmd]_ERROR() Anshuman Khandual
2026-08-12 11:21 ` David Hildenbrand (Arm)
2026-08-13 5:44 ` Anshuman Khandual
2026-08-11 4:21 ` [RFC V2 5/6] sh/mm: Stop using pgd_ERROR() Anshuman Khandual
2026-08-12 11:28 ` David Hildenbrand (Arm)
2026-08-11 4:21 ` [RFC V2 6/6] mm: Drop pxd_ERROR() Anshuman Khandual
2026-08-11 6:49 ` Geert Uytterhoeven
2026-08-11 8:34 ` Anshuman Khandual
2026-08-12 11:33 ` David Hildenbrand (Arm)
2026-08-13 6:03 ` Anshuman Khandual
2026-08-13 7:18 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bab5a5-76c9-4856-b314-49f19f54e229@kernel.org \
--to=david@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dalias@libc.org \
--cc=deller@gmx.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox