From: Niklas Schnelle <schnelle@linux.ibm.com>
To: William Breathitt Gray <wbg@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"William Breathitt Gray" <william.gray@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-pci@vger.kernel.org, "Arnd Bergmann" <arnd@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 07/44] counter: add HAS_IOPORT_MAP dependency
Date: Fri, 09 Jun 2023 16:57:27 +0200 [thread overview]
Message-ID: <f858c964f2fbe2fa5a92652c7d5022af7e3b76f1.camel@linux.ibm.com> (raw)
In-Reply-To: <ZIHs55tweGZTIiYk@ishi>
On Thu, 2023-06-08 at 10:59 -0400, William Breathitt Gray wrote:
> On Mon, May 22, 2023 at 12:50:12PM +0200, Niklas Schnelle wrote:
> > The 104_QUAD_8 counter driver uses devm_ioport_map() without depending
> > on HAS_IOPORT_MAP. This means the driver is not usable on platforms such
> > as s390 which do not support I/O port mapping. Add the missing
> > HAS_IOPORT_MAP dependency to make this explicit.
> >
> > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > ---
> > drivers/counter/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 4228be917038..e65a2bf178b8 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -15,6 +15,7 @@ if COUNTER
> > config 104_QUAD_8
> > tristate "ACCES 104-QUAD-8 driver"
> > depends on (PC104 && X86) || COMPILE_TEST
> > + depends on HAS_IOPORT_MAP
> > select ISA_BUS_API
> > help
> > Say yes here to build support for the ACCES 104-QUAD-8 quadrature
> > --
> > 2.39.2
> >
>
> This has a minor merge conflict with the current Kconfig in the Counter
> tree. Would you rebase on the counter-next branch and resubmit?
>
> Thanks,
>
> William Breathitt Gray
Sure can do. That said, using a three way merge as below doe handle the
conflict correctly:
% git checkout counter/counter-next
% b4 am -P _ 'https://lore.kernel.org/all/20230522105049.1467313-8-schnelle@linux.ibm.com/'
% git am -3 v5_20230522_schnelle_counter_add_has_ioport_map_dependency.mbx
next prev parent reply other threads:[~2023-06-09 14:58 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:50 [PATCH v5 00/44] treewide: Remove I/O port accessors for HAS_IOPORT=n Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 01/44] kgdb: add HAS_IOPORT dependency Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 02/44] ata: add HAS_IOPORT dependencies Niklas Schnelle
2023-05-22 11:49 ` Damien Le Moal
2023-05-22 10:50 ` [PATCH v5 03/44] char: " Niklas Schnelle
2023-07-04 8:09 ` Geert Uytterhoeven
2023-05-22 10:50 ` [PATCH v5 04/44] char: ipmi: handle " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 05/44] char: tpm: " Niklas Schnelle
2023-05-24 1:09 ` Jarkko Sakkinen
2023-05-24 3:13 ` Jarkko Sakkinen
2023-05-22 10:50 ` [PATCH v5 06/44] comedi: add " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 07/44] counter: add HAS_IOPORT_MAP dependency Niklas Schnelle
2023-06-08 14:59 ` William Breathitt Gray
2023-06-09 14:57 ` Niklas Schnelle [this message]
2023-05-22 10:50 ` [PATCH v5 08/44] /dev/port: don't compile file operations without CONFIG_DEVPORT Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 09/44] drm: handle HAS_IOPORT dependencies Niklas Schnelle
2023-05-22 12:38 ` Thomas Zimmermann
2023-05-22 13:06 ` Arnd Bergmann
2023-05-22 13:14 ` Gerd Hoffmann
2023-05-22 10:50 ` [PATCH v5 10/44] firmware: dmi-sysfs: handle HAS_IOPORT=n Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies Niklas Schnelle
2023-05-23 8:15 ` Bartosz Golaszewski
2023-05-22 10:50 ` [PATCH v5 12/44] hwmon: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 13/44] i2c: " Niklas Schnelle
2023-09-24 21:01 ` Wolfram Sang
2023-10-23 15:36 ` Wolfram Sang
2023-05-22 10:50 ` [PATCH v5 14/44] iio: ad7606: Kconfig: " Niklas Schnelle
2023-05-28 18:55 ` Jonathan Cameron
2023-05-30 9:21 ` Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 15/44] Input: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 16/44] Input: gameport: add ISA and " Niklas Schnelle
2023-05-22 22:16 ` Dmitry Torokhov
2023-05-22 10:50 ` [PATCH v5 17/44] leds: add " Niklas Schnelle
2023-05-25 11:21 ` Lee Jones
2023-05-22 10:50 ` [PATCH v5 18/44] media: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 19/44] misc: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 20/44] mISDN: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 21/44] mpt fusion: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 22/44] net: handle " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 23/44] parport: PC style parport depends on HAS_IOPORT Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 24/44] PCI: Make quirk using inw() depend " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 25/44] PCI/sysfs: Make I/O resource " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 26/44] pcmcia: add HAS_IOPORT dependencies Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 27/44] platform: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 28/44] pnp: " Niklas Schnelle
2023-05-22 11:54 ` Jaroslav Kysela
2023-05-22 10:50 ` [PATCH v5 29/44] power: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 30/44] rtc: " Niklas Schnelle
2023-05-22 13:09 ` Maciej W. Rozycki
2023-06-06 21:35 ` (subset) " Alexandre Belloni
2023-07-04 8:06 ` Geert Uytterhoeven
2023-07-04 11:25 ` Arnd Bergmann
2023-07-04 12:46 ` Geert Uytterhoeven
2023-05-22 10:50 ` [PATCH v5 31/44] scsi: " Niklas Schnelle
2023-05-22 22:28 ` Martin K. Petersen
2023-05-23 7:26 ` Niklas Schnelle
2023-06-01 0:00 ` Martin K. Petersen
2023-05-22 10:50 ` [PATCH v5 32/44] sound: " Niklas Schnelle
2023-05-22 11:55 ` Jaroslav Kysela
2023-05-22 11:59 ` Takashi Iwai
2023-05-22 13:54 ` Niklas Schnelle
2023-05-22 14:44 ` Takashi Iwai
2023-05-22 10:50 ` [PATCH v5 33/44] speakup: add HAS_IOPORT dependency for SPEAKUP_SERIALIO Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 34/44] staging: add HAS_IOPORT dependencies Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 35/44] tty: serial: handle " Niklas Schnelle
2023-05-30 14:39 ` Greg Kroah-Hartman
2023-05-22 10:50 ` [PATCH v5 36/44] usb: add " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 37/44] usb: uhci: handle " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 38/44] usb: pci-quirks: " Niklas Schnelle
2023-05-29 14:34 ` Greg Kroah-Hartman
2023-05-22 10:50 ` [PATCH v5 39/44] vgacon: add " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 40/44] fbdev: " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 41/44] video: Handle " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 42/44] watchdog: add " Niklas Schnelle
2023-05-22 10:50 ` [PATCH v5 43/44] wireless: " Niklas Schnelle
2023-05-24 7:38 ` Kalle Valo
2023-05-25 12:01 ` Niklas Schnelle
2023-05-25 16:08 ` [v5,43/44] wifi: " Kalle Valo
2023-05-22 10:50 ` [PATCH v5 44/44] asm-generic/io.h: Remove I/O port accessors for HAS_IOPORT=n Niklas Schnelle
2023-05-22 11:29 ` [PATCH v5 00/44] treewide: " Arnd Bergmann
2023-06-27 9:12 ` Niklas Schnelle
2023-06-27 12:53 ` Arnd Bergmann
2023-06-29 13:26 ` Niklas Schnelle
2023-06-08 1:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f858c964f2fbe2fa5a92652c7d5022af7e3b76f1.camel@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wbg@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).