From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [PATCH 24/56] microblaze_v2: time support Date: Tue, 6 May 2008 08:28:20 -0600 Message-ID: References: <1209901305-6404-1-git-send-email-monstr@seznam.cz> <1210033811.5798.188.camel@localhost> <48202C9E.7070800@seznam.cz> <200805061338.24870.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200805061338.24870.arnd@arndb.de> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: monstr@seznam.cz, John Williams , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au List-Id: linux-arch.vger.kernel.org On Tue, May 6, 2008 at 5:38 AM, Arnd Bergmann wrote: > On Tuesday 06 May 2008, Michal Simek wrote: > > I saw a lot of comments about files but I have never seen any comments that > > any file is OK. > > Does it mean everything is broken??? I don't think so. > > > I think you're doing a great job on this. Any patch set of this size that > has been maintained for a long time outside of the kernel goes through this > phase where everyone tells you what to improve, based on their experience, > while everything you do right about the patches is just taken for granted. > > Don't let yourself get discouraged by the negative comments, we're really > all just trying to help you do the right thing! Let me add my voice to Arnd's. This is a *big* task and you're handling it very well. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ag-out-0708.google.com ([72.14.246.242]:18083 "EHLO ag-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbYEFO2W (ORCPT ); Tue, 6 May 2008 10:28:22 -0400 Received: by ag-out-0708.google.com with SMTP id 31so1556776agc.10 for ; Tue, 06 May 2008 07:28:20 -0700 (PDT) Message-ID: Date: Tue, 6 May 2008 08:28:20 -0600 From: "Grant Likely" Subject: Re: [PATCH 24/56] microblaze_v2: time support In-Reply-To: <200805061338.24870.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1209901305-6404-1-git-send-email-monstr@seznam.cz> <1210033811.5798.188.camel@localhost> <48202C9E.7070800@seznam.cz> <200805061338.24870.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: monstr@seznam.cz, John Williams , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au Message-ID: <20080506142820.w_9Ej7-C5MgW7HzoemEODMGvpY6j7fCd0Sd6dI7_zBI@z> On Tue, May 6, 2008 at 5:38 AM, Arnd Bergmann wrote: > On Tuesday 06 May 2008, Michal Simek wrote: > > I saw a lot of comments about files but I have never seen any comments that > > any file is OK. > > Does it mean everything is broken??? I don't think so. > > > I think you're doing a great job on this. Any patch set of this size that > has been maintained for a long time outside of the kernel goes through this > phase where everyone tells you what to improve, based on their experience, > while everything you do right about the patches is just taken for granted. > > Don't let yourself get discouraged by the negative comments, we're really > all just trying to help you do the right thing! Let me add my voice to Arnd's. This is a *big* task and you're handling it very well. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.