From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1FE8F4A for ; Tue, 30 Apr 2024 04:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714451501; cv=none; b=Tsx3VQ51sYghAIvyrcFFYjOcDY13BWnvIkjb7P3tCl3dq47QYduDRJgQL6oKiGQae1domVFqrqseLCMbz0ymyDbaFDkpUnBMwInJ5xnsHu6W+GeYGcJoPvCJTYszewsTZ7qyG/8mfCDtzY27LSXOHLVTv11ABHJE5FcG0joZvcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714451501; c=relaxed/simple; bh=29uhAEoT45o4FIk7bCIeul9Jn+bmCAUKhTM2KMG4H2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O2m6Mu1HAnmAkGc3i0MJYEAKlrrdhvigBtp50X9c5Gmfj5xljAbQh4CLngjPn/6ukPDcc94JYijO3z+/QYUJjj2jaP8/BQWjb5AmO6Cm1HNLOthSha0IbzQqDzE/iIrKrOB/wg/kr5sKZ1uzWbipDYjpU3PL5aZhp8jbJYNEnTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Rk75F/O3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Rk75F/O3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714451498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i13MtWkwJ9CzG5rHobsEqX+W2OhJEVkbAyH/jjvfJXM=; b=Rk75F/O35rMfoj1PUEvUhooEBOOm9F+bpXgOe7kl0h+vfuktsqv68gP4nyGQnez57Zypva luxPaUfM533imFf7jJhz5B78ljJY/Ul+IgzNmvNM4Ax4mZ9WcPOloRYAzrLV5R2uRFstF8 A8LJMiweB/xbSPYQDm4jK6zplFaNGK0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-8MaG9IAPMHyF3WJmFQ4coA-1; Tue, 30 Apr 2024 00:31:36 -0400 X-MC-Unique: 8MaG9IAPMHyF3WJmFQ4coA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1eab16ca864so58944575ad.2 for ; Mon, 29 Apr 2024 21:31:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714451494; x=1715056294; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i13MtWkwJ9CzG5rHobsEqX+W2OhJEVkbAyH/jjvfJXM=; b=dd6nVl5I0ch0Lkh6wq4Y9kwA8vfRoQ+HWrls0JTkf+a+V1P/dngzULe3LzKR+ME/4z rds/UIcCqs06P3n5vkOOt3WLj/0EP8r3qXvMbwoTDngKkqLa7xOceCWaXQ+fVOl51mAJ 8Fk96TRFrrAKW1g9ZJmlItkPLmXCbKyAD8U4ZvCijV7ZuaXVVsp8XqJ5Zo05u9ajiF3c 3Nj0jPGoN2pQ/kcOnzRTKsI1nrm3Zy+mc2irnZM11QCA5gx700DnlR0YdrqQfLG7uijA GMR1AR9weU3jvLrAnRRt8XGiyAxRVG7elMjvigT1kArll0YgHGISxtZUtsSty+9oOXXT KSCg== X-Forwarded-Encrypted: i=1; AJvYcCXd07HTWn6mKqaBr3a1buPeLRLNI8JXIwosm+fy25+JJ3C8WGLQFnUYAA2tYVAa1s2ITDe4fGFwOkigY5ESsdwZcQKCzPJEUyYghA== X-Gm-Message-State: AOJu0YyY6SMQB3JcTMMsvdr+ij+PMeKFfBplgqgnkgV9Sw/k/3VO43Mw 7/HZQwfIOqz2eBMxh0JwMy5wH10utgKY4df+8JE01h8pKCjRFGASa3NPTOj6bKSHjtty6WHj1Wt XoUSe0r0kmdSRpVQgAJNM9B09P1uQTPB4BSVLH5VKqii6i++9gV26r7yNL9k= X-Received: by 2002:a17:902:d2c8:b0:1e4:4000:a576 with SMTP id n8-20020a170902d2c800b001e44000a576mr14606369plc.43.1714451494083; Mon, 29 Apr 2024 21:31:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAw003t6HOSoCLpW/XUCLqCM5arMxu8YIqu/zbz1Hwe4t+r/fC177o/TfutrGEBjD75Dh+aQ== X-Received: by 2002:a17:902:d2c8:b0:1e4:4000:a576 with SMTP id n8-20020a170902d2c800b001e44000a576mr14606349plc.43.1714451493684; Mon, 29 Apr 2024 21:31:33 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.88]) by smtp.gmail.com with ESMTPSA id jv12-20020a170903058c00b001eab3baad5dsm8939394plb.4.2024.04.29.21.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 21:31:33 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 14:31:22 +1000 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 13/16] arm64: arch_register_cpu() variant to check if an ACPI handle is now available. Content-Language: en-US To: Jonathan Cameron , Thomas Gleixner , Peter Zijlstra , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Marc Zyngier , Hanjun Guo Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com, Lorenzo Pieralisi , Sudeep Holla References: <20240426135126.12802-1-Jonathan.Cameron@huawei.com> <20240426135126.12802-14-Jonathan.Cameron@huawei.com> From: Gavin Shan In-Reply-To: <20240426135126.12802-14-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/26/24 23:51, Jonathan Cameron wrote: > The ARM64 architecture does not support physical CPU HP today. > To avoid any possibility of a bug against such an architecture if defined > in future, check for the physical CPU HP case (not present) and > return an error on any such attempt. > > On ARM64 virtual CPU Hotplug relies on the status value that can be > queried via the AML method _STA for the CPU object. > > There are two conditions in which the CPU can be registered. > 1) ACPI disabled. > 2) ACPI enabled and the acpi_handle is available. > _STA evaluates to the CPU is both enabled and present. > (Note that in absence of the _STA method they are always in this > state). > > If neither of these conditions is met the CPU is not 'yet' ready > to be used and -EPROBE_DEFER is returned. > > Success occurs in the early attempt to register the CPUs if we > are booting with DT (no concept yet of vCPU HP) if not it succeeds > for already enabled CPUs when the ACPI Processor driver attaches to > them. Finally it may succeed via the CPU Hotplug code indicating that > the CPU is now enabled. > > For ACPI if CONFIG_ACPI_PROCESSOR the only path to get to > arch_register_cpu() with that handle set is via > acpi_processor_hot_add_init() which is only called from an ACPI bus > scan in which _STA has already been queried there is no need to > repeat it here. Add a comment to remind us of this in the future. > > Suggested-by: Rafael J. Wysocki > Tested-by: Miguel Luis > Signed-off-by: Jonathan Cameron > --- > V8: No change. (tags collected only) > --- > arch/arm64/kernel/smp.c | 53 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > Reviewed-by: Gavin Shan