From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH v3 3/3] microblaze: generate uapi header and system call table files Date: Thu, 8 Nov 2018 14:50:15 +0100 Message-ID: References: <1540530552-3652-1-git-send-email-firoz.khan@linaro.org> <1540530552-3652-4-git-send-email-firoz.khan@linaro.org> Reply-To: monstr@monstr.eu Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann , Firoz Khan Cc: gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW Content-Type: multipart/mixed; boundary="uDZve51gLKziK3cpsalbKpnaVvLnhVV32"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Arnd Bergmann , Firoz Khan Cc: gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: Subject: Re: [PATCH v3 3/3] microblaze: generate uapi header and system call table files References: <1540530552-3652-1-git-send-email-firoz.khan@linaro.org> <1540530552-3652-4-git-send-email-firoz.khan@linaro.org> In-Reply-To: --uDZve51gLKziK3cpsalbKpnaVvLnhVV32 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08. 11. 18 14:44, Arnd Bergmann wrote: > On Mon, Nov 5, 2018 at 11:26 AM Firoz Khan wrot= e: >> On Mon, 5 Nov 2018 at 14:46, Michal Simek wrote: >>> On 26. 10. 18 7:09, Firoz Khan wrote: >=20 >>>> - .long sys_rseq >>>> +#include >>>> +#undef __SYSCALL >>>> >>> >>> I still don't think this is correct. >>> >>> I have done these steps >>> >>> make mrproper >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 1/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 2/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 3/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> >>> And compare all these versions. Till 2/3 all is fine but when 3/3 is >>> applied >>> >>> include/asm/unistd.h contains >>> #include >>> >>> Then include/asm/unistd_32.h contains >>> #include >>> which is different syscalls table. >>> >>> I didn't play with it for a long time but removing generic unistd_32.= h >>> is fixing it. Please take a look. >> >> Sure, I'll check and update you ASAP. >> >>> >>> diff --git a/arch/microblaze/include/uapi/asm/Kbuild >>> b/arch/microblaze/include/uapi/asm/Kbuild >>> index cda864f4b62e..2c6a6bffea32 100644 >>> --- a/arch/microblaze/include/uapi/asm/Kbuild >>> +++ b/arch/microblaze/include/uapi/asm/Kbuild >>> @@ -28,4 +28,3 @@ generic-y +=3D termbits.h >>> generic-y +=3D termios.h >>> generic-y +=3D types.h >>> generic-y +=3D ucontext.h >>> -generic-y +=3D unistd_32.h >> >> AFAIK, If I apply the above fix; the generated file - unistd_32.h will= >> get removed. >> No longer present in arch/microblaze/include/generated/uapi/asm. >=20 > It certainly must be 'generated-y', not 'generic-y', since you are > generating an architecture specific file, not taking the one > from asm-generic. I think this was correct in an earlier version. yep. It was correct in v1. It has changed in v2. I have retested and it looks good with that. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs --uDZve51gLKziK3cpsalbKpnaVvLnhVV32-- --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlvkPxcACgkQykllyylKDCFdIgCcCsKaEPsvueRfy+fm0ZIPS/sk JNwAni9w/jKcUrvC34RftpffS3unNnpf =lgFx -----END PGP SIGNATURE----- --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:38797 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbeKHXZ7 (ORCPT ); Thu, 8 Nov 2018 18:25:59 -0500 Received: by mail-wr1-f67.google.com with SMTP id d10-v6so21330931wrs.5 for ; Thu, 08 Nov 2018 05:50:24 -0800 (PST) Reply-To: monstr@monstr.eu Subject: Re: [PATCH v3 3/3] microblaze: generate uapi header and system call table files References: <1540530552-3652-1-git-send-email-firoz.khan@linaro.org> <1540530552-3652-4-git-send-email-firoz.khan@linaro.org> From: Michal Simek Message-ID: Date: Thu, 8 Nov 2018 14:50:15 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann , Firoz Khan Cc: gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20181108135015.KBj-TpnW8_LC42tzTECd9ttWZGYblU5PZlBNqAb-x4k@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW Content-Type: multipart/mixed; boundary="uDZve51gLKziK3cpsalbKpnaVvLnhVV32"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Arnd Bergmann , Firoz Khan Cc: gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: Subject: Re: [PATCH v3 3/3] microblaze: generate uapi header and system call table files References: <1540530552-3652-1-git-send-email-firoz.khan@linaro.org> <1540530552-3652-4-git-send-email-firoz.khan@linaro.org> In-Reply-To: --uDZve51gLKziK3cpsalbKpnaVvLnhVV32 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08. 11. 18 14:44, Arnd Bergmann wrote: > On Mon, Nov 5, 2018 at 11:26 AM Firoz Khan wrot= e: >> On Mon, 5 Nov 2018 at 14:46, Michal Simek wrote: >>> On 26. 10. 18 7:09, Firoz Khan wrote: >=20 >>>> - .long sys_rseq >>>> +#include >>>> +#undef __SYSCALL >>>> >>> >>> I still don't think this is correct. >>> >>> I have done these steps >>> >>> make mrproper >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 1/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 2/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> Applied 3/3 >>> make ARCH=3Dmicroblaze headers_install INSTALL_HDR_PATH=3D/tmp/ && mo= ve >>> >>> And compare all these versions. Till 2/3 all is fine but when 3/3 is >>> applied >>> >>> include/asm/unistd.h contains >>> #include >>> >>> Then include/asm/unistd_32.h contains >>> #include >>> which is different syscalls table. >>> >>> I didn't play with it for a long time but removing generic unistd_32.= h >>> is fixing it. Please take a look. >> >> Sure, I'll check and update you ASAP. >> >>> >>> diff --git a/arch/microblaze/include/uapi/asm/Kbuild >>> b/arch/microblaze/include/uapi/asm/Kbuild >>> index cda864f4b62e..2c6a6bffea32 100644 >>> --- a/arch/microblaze/include/uapi/asm/Kbuild >>> +++ b/arch/microblaze/include/uapi/asm/Kbuild >>> @@ -28,4 +28,3 @@ generic-y +=3D termbits.h >>> generic-y +=3D termios.h >>> generic-y +=3D types.h >>> generic-y +=3D ucontext.h >>> -generic-y +=3D unistd_32.h >> >> AFAIK, If I apply the above fix; the generated file - unistd_32.h will= >> get removed. >> No longer present in arch/microblaze/include/generated/uapi/asm. >=20 > It certainly must be 'generated-y', not 'generic-y', since you are > generating an architecture specific file, not taking the one > from asm-generic. I think this was correct in an earlier version. yep. It was correct in v1. It has changed in v2. I have retested and it looks good with that. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs --uDZve51gLKziK3cpsalbKpnaVvLnhVV32-- --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlvkPxcACgkQykllyylKDCFdIgCcCsKaEPsvueRfy+fm0ZIPS/sk JNwAni9w/jKcUrvC34RftpffS3unNnpf =lgFx -----END PGP SIGNATURE----- --tRrjEZXu1k8fcGaS9MXYcwQYxLQlzNZzW--