From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hajime Tazaki Subject: Re: [RFC PATCH 01/11] sysctl: make some functions unstatic to access by arch/lib Date: Thu, 26 Mar 2015 00:31:09 +0900 Message-ID: References: <1427202642-1716-1-git-send-email-tazaki@sfc.wide.ad.jp> <1427202642-1716-2-git-send-email-tazaki@sfc.wide.ad.jp> <1427213619.5642.34.camel@perches.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1427213619.5642.34.camel@perches.com> Sender: owner-linux-mm@kvack.org To: joe@perches.com Cc: linux-arch@vger.kernel.org, arnd@arndb.de, corbet@lwn.net, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, jdike@addtoit.com, richard@nod.at, rusty@rustcorp.com.au, mathieu.lacage@gmail.com List-Id: linux-arch.vger.kernel.org At Tue, 24 Mar 2015 09:13:39 -0700, Joe Perches wrote: > > On Tue, 2015-03-24 at 22:10 +0900, Hajime Tazaki wrote: > > libos (arch/lib) emulates a sysctl-like interface by a function call of > > userspace by enumerating sysctl tree from sysctl_table_root. It requires > > to be publicly accessible to this symbol and related functions. > [] > > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c > [] > > @@ -77,7 +77,7 @@ static int namecmp(const char *name1, int len1, const char *name2, int len2) > > } > > > > /* Called under sysctl_lock */ > > -static struct ctl_table *find_entry(struct ctl_table_header **phead, > > +struct ctl_table *find_entry(struct ctl_table_header **phead, > > find_entry and all of the _entry functions below it > are overly generic names. Maybe prefix with ctl_table_ agree. I will address this in the next version of the patch. thanks. -- Hajime -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shonan.sfc.wide.ad.jp ([203.178.142.130]:35951 "EHLO mail.sfc.wide.ad.jp" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753319AbbCYPbN (ORCPT ); Wed, 25 Mar 2015 11:31:13 -0400 Date: Thu, 26 Mar 2015 00:31:09 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC PATCH 01/11] sysctl: make some functions unstatic to access by arch/lib In-Reply-To: <1427213619.5642.34.camel@perches.com> References: <1427202642-1716-1-git-send-email-tazaki@sfc.wide.ad.jp> <1427202642-1716-2-git-send-email-tazaki@sfc.wide.ad.jp> <1427213619.5642.34.camel@perches.com> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: joe@perches.com Cc: linux-arch@vger.kernel.org, arnd@arndb.de, corbet@lwn.net, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, jdike@addtoit.com, richard@nod.at, rusty@rustcorp.com.au, mathieu.lacage@gmail.com Message-ID: <20150325153109.V_sMzf4SD6L3dGOhXc1aXmVt81ppxLKlD5XifHf-RKA@z> At Tue, 24 Mar 2015 09:13:39 -0700, Joe Perches wrote: > > On Tue, 2015-03-24 at 22:10 +0900, Hajime Tazaki wrote: > > libos (arch/lib) emulates a sysctl-like interface by a function call of > > userspace by enumerating sysctl tree from sysctl_table_root. It requires > > to be publicly accessible to this symbol and related functions. > [] > > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c > [] > > @@ -77,7 +77,7 @@ static int namecmp(const char *name1, int len1, const char *name2, int len2) > > } > > > > /* Called under sysctl_lock */ > > -static struct ctl_table *find_entry(struct ctl_table_header **phead, > > +struct ctl_table *find_entry(struct ctl_table_header **phead, > > find_entry and all of the _entry functions below it > are overly generic names. Maybe prefix with ctl_table_ agree. I will address this in the next version of the patch. thanks. -- Hajime