From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: ak@suse.de Subject: Re: [PATCH 3/3] sanitize building of fs/compat_ioctl.c References: <20051213172325.GC16392@lst.de> <20051213173434.GP9286@parisc-linux.org> <20051213.145109.20744871.davem@davemloft.net> From: Andi Kleen Date: 14 Dec 2005 02:41:42 +0100 In-Reply-To: <20051213.145109.20744871.davem@davemloft.net> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: "David S. Miller" Cc: hch@lst.de, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-ID: "David S. Miller" writes: > From: Matthew Wilcox > Date: Tue, 13 Dec 2005 10:34:34 -0700 > > > The 64-bit code doesn't compile because Andi keeps blocking the > > is_compat_task() stuff. > > The one place where I ever thought that was necessary, the > USB async userspace I/O operation stuff, was solved much more > cleanly with ->compat_ioctl() file_operations handlers. > > What do you really still need it for at this point? input needs it :/ Take a look at drivers/input/evdev.c:evdev_write_compat Someone should roast in hell for that code. > I also would like to avoid it if possible. I have given in for now. Assuming the test is done on a flag that is only set by the system call entry path. But I still think it will result in a lot of ugly code. For for read/write it's hard to avoid because there are so many variants and we have too many message passing protocols now. That said I have been too lazy so far to actually implement it:/ -Andi