From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: SB16 build error. Date: Thu, 30 Jun 2011 13:05:54 +0200 Message-ID: References: <20110630091754.GA12119@linux-mips.org> <20110630105254.GA25732@linux-mips.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-2022-JP Return-path: In-Reply-To: <20110630105254.GA25732@linux-mips.org> Sender: sparclinux-owner@vger.kernel.org To: Ralf Baechle Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, florian@linux-mips.org, Florian Fainelli , linux-arch@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , sparclinux@vger.kernel.org List-Id: linux-arch.vger.kernel.org At Thu, 30 Jun 2011 11:52:54 +0100, Ralf Baechle wrote: > > On Thu, Jun 30, 2011 at 12:15:56PM +0200, Takashi Iwai wrote: > > > At Thu, 30 Jun 2011 10:17:54 +0100, > > Ralf Baechle wrote: > > > > > > Found on a MIPS build but certain other architectures will have the same > > > issue: > > > > > > CC sound/isa/sb/sb16_csp.o > > > sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’: > > > sound/isa/sb/sb16_csp.c:228: error: case label does not reduce to an integer constant > > > make[1]: *** [sound/isa/sb/sb16_csp.o] Error 1 > > > make: *** [sound/isa/sb/sb16_csp.o] Error 2 > > > > > > This error message is caused by the _IOC_TYPECHECK() error check triggering > > > due to excessive ioctl size on Alpha, PowerPC, MIPS and SPARC which define > > > _IOC_SIZEBITS as 13. On all other architectures define it as 14 so struct > > > snd_sb_csp_microcode with it's little over 12kB will just about fit into > > > the 16kB limit. > > > > What about the patch below? > > I have no idea how big the soundblaster microcode being loaded actually is, > that is if the reduced size of 0x1f00 will be sufficient. The files found in /lib/firmware/sb16 are all under 2kB, thus likely sufficient. > Aside of that I > don't see a problem - I don't see how the old ioctl can possibly have been > used before so there isn't a compatibility problem. > > Or you could entirely sidestep the problem and use request_firmware() but > I guess that's more effort than you want to invest. Yeah, that's another option I thought of. But it's too intrusive for 3.0-rc6, so I'd like waive it for 3.1. > > This is an old ISA driver, so the impact must be very low. > > True. I notice that sort of stuff in automated mass builds - not > necessarily the sort of kernels one would actually use. Still build errors > are annoying :) Right, better to fix it up quickly. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:36175 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481Ab1F3LF4 (ORCPT ); Thu, 30 Jun 2011 07:05:56 -0400 Date: Thu, 30 Jun 2011 13:05:54 +0200 Message-ID: From: Takashi Iwai Subject: Re: SB16 build error. In-Reply-To: <20110630105254.GA25732@linux-mips.org> References: <20110630091754.GA12119@linux-mips.org> <20110630105254.GA25732@linux-mips.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-2022-JP Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ralf Baechle Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, florian@linux-mips.org, Florian Fainelli , linux-arch@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , sparclinux@vger.kernel.org Message-ID: <20110630110554.NIIvvGPLZUHoiUnTGTIw87-qf4C_3O6fsBbhoDWWzjY@z> At Thu, 30 Jun 2011 11:52:54 +0100, Ralf Baechle wrote: > > On Thu, Jun 30, 2011 at 12:15:56PM +0200, Takashi Iwai wrote: > > > At Thu, 30 Jun 2011 10:17:54 +0100, > > Ralf Baechle wrote: > > > > > > Found on a MIPS build but certain other architectures will have the same > > > issue: > > > > > > CC sound/isa/sb/sb16_csp.o > > > sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’: > > > sound/isa/sb/sb16_csp.c:228: error: case label does not reduce to an integer constant > > > make[1]: *** [sound/isa/sb/sb16_csp.o] Error 1 > > > make: *** [sound/isa/sb/sb16_csp.o] Error 2 > > > > > > This error message is caused by the _IOC_TYPECHECK() error check triggering > > > due to excessive ioctl size on Alpha, PowerPC, MIPS and SPARC which define > > > _IOC_SIZEBITS as 13. On all other architectures define it as 14 so struct > > > snd_sb_csp_microcode with it's little over 12kB will just about fit into > > > the 16kB limit. > > > > What about the patch below? > > I have no idea how big the soundblaster microcode being loaded actually is, > that is if the reduced size of 0x1f00 will be sufficient. The files found in /lib/firmware/sb16 are all under 2kB, thus likely sufficient. > Aside of that I > don't see a problem - I don't see how the old ioctl can possibly have been > used before so there isn't a compatibility problem. > > Or you could entirely sidestep the problem and use request_firmware() but > I guess that's more effort than you want to invest. Yeah, that's another option I thought of. But it's too intrusive for 3.0-rc6, so I'd like waive it for 3.1. > > This is an old ISA driver, so the impact must be very low. > > True. I notice that sort of stuff in automated mass builds - not > necessarily the sort of kernels one would actually use. Still build errors > are annoying :) Right, better to fix it up quickly. thanks, Takashi