linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Kees Cook <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: elena.reshetova@intel.com, akpm@linux-foundation.org,
	dave@stgolabs.net, adobriyan@gmail.com, ebiggers3@gmail.com,
	jannh@google.com, torvalds@linux-foundation.org,
	jpoimboe@redhat.com, manfred@colorfullife.com,
	peterz@infradead.org, serge@hallyn.com, ebiederm@xmission.com,
	gregkh@linuxfoundation.org, hpa@zytor.com, tglx@linutronix.de,
	ishkamiel@gmail.com, keescook@chromium.org, davem@davemloft.net,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	riel@redhat.com, arnd@arndb.de, mingo@kernel.org,
	hch@infradead.org, James.Bottomley@hansenpartnership.com
Subject: [tip:x86/asm] x86/asm: Add ASM_UNREACHABLE
Date: Tue, 25 Jul 2017 06:49:02 -0700	[thread overview]
Message-ID: <tip-aa5d1b81500e6059190f18fe25a7617682321910@git.kernel.org> (raw)
In-Reply-To: <1500921349-10803-3-git-send-email-keescook@chromium.org>

Commit-ID:  aa5d1b81500e6059190f18fe25a7617682321910
Gitweb:     http://git.kernel.org/tip/aa5d1b81500e6059190f18fe25a7617682321910
Author:     Kees Cook <keescook@chromium.org>
AuthorDate: Mon, 24 Jul 2017 11:35:48 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 25 Jul 2017 11:18:09 +0200

x86/asm: Add ASM_UNREACHABLE

This creates an unreachable annotation in asm for CONFIG_STACK_VALIDATION=y.
While here, adjust earlier uses of \t\n into \n\t.

Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Elena Reshetova <elena.reshetova@intel.com>
Cc: Eric Biggers <ebiggers3@gmail.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans Liljestrand <ishkamiel@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Jann Horn <jannh@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Serge E. Hallyn <serge@hallyn.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: arozansk@redhat.com
Cc: axboe@kernel.dk
Cc: kernel-hardening@lists.openwall.com
Cc: linux-arch <linux-arch@vger.kernel.org>
Link: http://lkml.kernel.org/r/1500921349-10803-3-git-send-email-keescook@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 include/linux/compiler-gcc.h | 13 +++++++++----
 include/linux/compiler.h     |  3 +++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index cd4bbe8..179375b 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -203,11 +203,16 @@
 
 #ifdef CONFIG_STACK_VALIDATION
 #define annotate_unreachable() ({					\
-	asm("%c0:\t\n"							\
-	    ".pushsection .discard.unreachable\t\n"			\
-	    ".long %c0b - .\t\n"					\
-	    ".popsection\t\n" : : "i" (__LINE__));			\
+	asm("%c0:\n\t"							\
+	    ".pushsection .discard.unreachable\n\t"			\
+	    ".long %c0b - .\n\t"					\
+	    ".popsection\n\t" : : "i" (__LINE__));			\
 })
+#define ASM_UNREACHABLE							\
+	"999:\n\t"							\
+	".pushsection .discard.unreachable\n\t"				\
+	".long 999b - .\n\t"						\
+	".popsection\n\t"
 #else
 #define annotate_unreachable()
 #endif
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 219f82f..641f591 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -185,6 +185,9 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
 #endif
 
 /* Unreachable code */
+#ifndef ASM_UNREACHABLE
+# define ASM_UNREACHABLE
+#endif
 #ifndef unreachable
 # define unreachable() do { } while (1)
 #endif

  parent reply	other threads:[~2017-07-25 13:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 18:35 [PATCH v8 0/3] x86: Implement fast refcount overflow protection Kees Cook
2017-07-24 18:35 ` Kees Cook
2017-07-24 18:35 ` [PATCH v8 1/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Kees Cook
2017-07-24 18:35   ` Kees Cook
2017-07-25 13:48   ` [tip:x86/asm] " tip-bot for Kees Cook
2017-07-24 18:35 ` [PATCH v8 2/3] x86/asm: add ASM_UNREACHABLE Kees Cook
2017-07-24 18:35   ` Kees Cook
2017-07-25 13:49   ` tip-bot for Kees Cook [this message]
2017-07-25 13:49     ` [tip:x86/asm] x86/asm: Add ASM_UNREACHABLE tip-bot for Kees Cook
2017-07-24 18:35 ` [PATCH v8 3/3] x86/refcount: Implement fast refcount overflow protection Kees Cook
2017-07-24 18:35   ` Kees Cook
2017-07-25 12:03   ` [kernel-hardening] " Li Kun
2017-07-25 12:03     ` Li Kun
2017-07-25 19:11     ` Kees Cook
2017-07-25 19:11       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-aa5d1b81500e6059190f18fe25a7617682321910@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=dave@stgolabs.net \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=ebiggers3@gmail.com \
    --cc=elena.reshetova@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=ishkamiel@gmail.com \
    --cc=jannh@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=serge@hallyn.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).